Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: use datetime.now() with timezone to handle DST correctly#531

Merged
larkee merged 5 commits intomasterfrom
fix-496
Aug 23, 2021
Merged

tests: use datetime.now() with timezone to handle DST correctly#531
larkee merged 5 commits intomasterfrom
fix-496

Conversation

@larkee
Copy link
Copy Markdown
Contributor

@larkee larkee commented Aug 23, 2021 •
edited
Loading

Closes #496
Closes #489

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2021
@larkee larkee marked this pull request as ready for review August 23, 2021 04:02
@larkee larkee requested a review from a team August 23, 2021 04:02
@larkee larkee requested a review from tseaver August 23, 2021 04:30
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
hengfengli
hengfengli approved these changes Aug 23, 2021
View reviewed changes
Copy link
Copy Markdown

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee merged commit 098a786 into master Aug 23, 2021
@larkee larkee deleted the fix-496 branch August 23, 2021 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tseaver tseaver tseaver approved these changes

@hengfengli hengfengli hengfengli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests.system.test_backup_api: test_instance_list_backups failed tests.system.test_backup_api: test_backup_workflow failed

4 participants

@larkee @tseaver @hengfengli @yoshi-kokoro