Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

ci: split systests into separate Kokoro session#481

Merged
tseaver merged 2 commits intomasterfrom
478-split-systests-to-separate-ci-session
Aug 12, 2021
Merged

ci: split systests into separate Kokoro session#481
tseaver merged 2 commits intomasterfrom
478-split-systests-to-separate-ci-session

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Aug 10, 2021

Closes #478.

@tseaver tseaver requested review from a team and larkee August 10, 2021 18:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 10, 2021
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 10, 2021

@larkee Note that this change will require a corresponding change to the Kokoro config in google, similar to the ones @tswast has made recently for datastore (googleapis/python-datastore#205), firestore (googleapis/python-firestore#412), and bigtable (googleapis/python-bigtable#390).

@tseaver tseaver merged commit d557a8d into master Aug 12, 2021
@tseaver tseaver deleted the 478-split-systests-to-separate-ci-session branch August 12, 2021 17:55
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 12, 2021

@larkee Hmm, I see that the system tests are skipped in the main Kokoro build:

nox > Running session system-3.8
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/system-3-8
nox > Session system-3.8 skipped: RUN_SYSTEM_TESTS is set to false, skipping.

but I don't see the new build which runs them in a separate job: the prior Github Action which runs system tests against the emulator is still here, but there is no Kokoro system-3.8 job present.

1 similar comment
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 12, 2021

@larkee Hmm, I see that the system tests are skipped in the main Kokoro build:

nox > Running session system-3.8
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/system-3-8
nox > Session system-3.8 skipped: RUN_SYSTEM_TESTS is set to false, skipping.

but I don't see the new build which runs them in a separate job: the prior Github Action which runs system tests against the emulator is still here, but there is no Kokoro system-3.8 job present.

@larkee
Copy link
Copy Markdown
Contributor

larkee commented Aug 13, 2021

but I don't see the new build which runs them in a separate job: the prior Github Action which runs system tests against the emulator is still here, but there is no Kokoro system-3.8 job present.

Ahh, I missed adding the new config file 😅 I've sent the change out for review so it should be submitted tomorrow 👍

tseaver added a commit that referenced this pull request Aug 18, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split out system tests into separate Kokoro job

2 participants