Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add progress field to UpdateDatabaseDdlMetadata#361

Merged
larkee merged 7 commits intomasterfrom
fix-owlbot-py
Jun 7, 2021
Merged

feat: add progress field to UpdateDatabaseDdlMetadata#361
larkee merged 7 commits intomasterfrom
fix-owlbot-py

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Jun 3, 2021 •
edited
Loading

This PR includes the latest generated client from googleapis-gen. I also modified the owlbot.py script to properly copy multiple versions from googleapis-gen here.

This PR also includes the following features and fixes:

feat: move import of CommitResponse
fix: add async client to %name_%version/init.py
chore: add autogenerated snippets
chore: remove auth, policy, and options from the reserved names list
feat: support self-signed JWT flow for service accounts
chore: enable GAPIC metadata generation
chore: sort subpackages in %namespace/%name/init.py

@parthea parthea requested review from a team and larkee June 3, 2021 12:16
@parthea parthea requested a review from a team as a code owner June 3, 2021 12:16
@parthea parthea requested review from crwilcox and removed request for a team June 3, 2021 12:16
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jun 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2021
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 3, 2021 •
edited
Loading

The build has the following error: ImportError: cannot import name 'CommitResponse' . I'm looking into it.

==================================== ERRORS ====================================
_________________ ERROR collecting tests/system/test_system.py _________________
ImportError while importing test module '/home/runner/work/python-spanner/python-spanner/tests/system/test_system.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/system/test_system.py:33: in <module>
    from google.cloud.spanner_v1 import param_types
google/cloud/spanner_v1/__init__.py:37: in <module>
    from .types.spanner import CommitResponse
E   ImportError: cannot import name 'CommitResponse' from 'google.cloud.spanner_v1.types.spanner' (/home/runner/work/python-spanner/python-spanner/google/cloud/spanner_v1/types/spanner.py)
______________ ERROR collecting tests/system/test_system_dbapi.py ______________
ImportError while importing test module '/home/runner/work/python-spanner/python-spanner/tests/system/test_system_dbapi.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/system/test_system_dbapi.py:23: in <module>
    from google.cloud.spanner_v1 import BurstyPool
google/cloud/spanner_v1/__init__.py:37: in <module>
    from .types.spanner import CommitResponse
E   ImportError: cannot import name 'CommitResponse' from 'google.cloud.spanner_v1.types.spanner' (/home/runner/work/python-spanner/python-spanner/google/cloud/spanner_v1/types/spanner.py)

@parthea parthea marked this pull request as draft June 3, 2021 12:20
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 3, 2021 •
edited
Loading

There is an issue with the docs. I was able to resolve the issue by removing the headings in this docstring .

sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/python-spanner/google/cloud/spanner_v1/types/transaction.py:docstring of google.cloud.spanner_v1.types.transaction.TransactionOptions:4:Unexpected section title.

I'll add a workaround in owlbot.py . I've suggested an update to the source proto to remove the headings based on AIP-192. Googlers see cl/377290854

Headings and tables must not be used, as these cause problems for several tools, and are unsuitable for client library reference documentation.

@parthea parthea marked this pull request as ready for review June 3, 2021 16:04
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 3, 2021
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 4, 2021

I'm going to switch this back to draft. It should be ready for review tomorrow.

@parthea parthea marked this pull request as draft June 4, 2021 00:03
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 6, 2021
@parthea parthea marked this pull request as ready for review June 6, 2021 12:13
@larkee larkee merged commit 1c03dcc into master Jun 7, 2021
@larkee larkee deleted the fix-owlbot-py branch June 7, 2021 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@larkee larkee larkee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@larkee larkee

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @larkee