Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add support for JSON type#353

Merged
larkee merged 22 commits intogoogleapis:masterfrom
asthamohta:json-spanner
Aug 26, 2021
Merged

feat: add support for JSON type#353
larkee merged 22 commits intogoogleapis:masterfrom
asthamohta:json-spanner

Conversation

@asthamohta
Copy link
Copy Markdown
Contributor

feat: add support for JSON type

@asthamohta asthamohta requested a review from a team May 19, 2021 12:17
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label May 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@asthamohta asthamohta requested review from larkee, vi3k6i5 and zoercai May 19, 2021 12:18
@larkee larkee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2021
Copy link
Copy Markdown
Contributor

@zoercai zoercai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for functionality in general and test examples, I'll leave the implementation/Python review to @larkee

Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skuruppu
Copy link
Copy Markdown
Contributor

skuruppu commented Jul 5, 2021

@asthamohta we merged the code generation PR, so you should now be able to rebase and hopefully get rid of the generated code from the PR.

@zoercai zoercai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2021
@zoercai zoercai removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2021
@zoercai zoercai added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@asthamohta asthamohta added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021
@zoercai zoercai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@larkee larkee merged commit b1dd04d into googleapis:master Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants