Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: migrate to owl bot#319

Merged
gcf-merge-on-green[bot] merged 5 commits intomasterfrom
owl-bot
Apr 28, 2021
Merged

chore: migrate to owl bot#319
gcf-merge-on-green[bot] merged 5 commits intomasterfrom
owl-bot

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Apr 26, 2021

This PR migrates from autosynth to owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run synthtool to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates. With owl bot, on every PR, a post-processor image will run so that we won't have to ask contributors to run blacken.

@parthea parthea requested a review from a team April 26, 2021 00:27
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Apr 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2021
@parthea parthea requested a review from a team as a code owner April 26, 2021 00:28
@parthea parthea requested review from crwilcox and removed request for a team April 26, 2021 00:28
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@larkee
Copy link
Copy Markdown
Contributor

larkee commented Apr 26, 2021

@parthea Would I be able to get some context on this?

@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Apr 26, 2021

Hi @larkee , all of the googleapis/python-* repositories are moving away from using autosynth. We will use owl bot instead in order to save time for maintainers. I've updated the body of the original post with this context. Please reach out to me if you have additional questions!

Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM?

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit eccbd0d into master Apr 28, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot branch April 28, 2021 12:34
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 28, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 1, 2021
There is [an issue](https://github.com/googleapis/python-spanner/blob/master/owlbot.py#L30) in the `owlbot.py` file added in #319 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over.  [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants