This repository was archived by the owner on Mar 31, 2026. It is now read-only.
chore!: remove Python 2.7 from testing#22
Merged
larkee merged 4 commits intogoogleapis:masterfrom Feb 20, 2020
Merged
Conversation
eaa88ea to
8fe007e
Compare
Contributor
|
Thanks @larkee! Can you also remove the classifiers from setup.py? https://github.com/googleapis/python-spanner/blob/master/setup.py#L73 Also, if we make this change, it would be best to consider it a breaking change. Any user who is pinning to the current major could be broken by us accidentally later. |
crwilcox
approved these changes
Feb 20, 2020
Closed
larkee
added a commit
that referenced
this pull request
Feb 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2.7 has been deprecated which means we no longer need to run these tests to ensure compatibility. Removing these will significantly speed up the presubmit checks.