Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore(spanner): Issue1178# [spanner_dbapi] While running a query that contains just comment, it causes an IndexError exception#1181

Merged
harshachinta merged 4 commits intogoogleapis:mainfrom
bhatt4982:Issue1178#-crash-while-running-comment-only-query
Aug 27, 2024
Merged

chore(spanner): Issue1178# [spanner_dbapi] While running a query that contains just comment, it causes an IndexError exception#1181
harshachinta merged 4 commits intogoogleapis:mainfrom
bhatt4982:Issue1178#-crash-while-running-comment-only-query

Conversation

@bhatt4982
Copy link
Copy Markdown
Contributor

@bhatt4982 bhatt4982 commented Aug 6, 2024

chore(spanner): Issue1178# [spanner_dbapi] While running a query that contains just comment, it causes an IndexError exception

  • returned ProgrammingError - Invalid statement

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1178 🦕

@bhatt4982
chore(spanner): Issue1178# [spanner_dbapi] While running a query that…
46bd126 
… contains just comment, it causes an IndexError exception

- returned ProgrammingError - Invalid statement
@bhatt4982 bhatt4982 requested a review from a team as a code owner August 6, 2024 06:59
@bhatt4982 bhatt4982 requested a review from a team August 6, 2024 06:59
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Aug 6, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Aug 6, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2024
@harshachinta harshachinta enabled auto-merge (squash) August 26, 2024 05:18
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@harshachinta harshachinta merged commit bd62d7c into googleapis:main Aug 27, 2024
@bhatt4982 bhatt4982 deleted the Issue1178#-crash-while-running-comment-only-query branch August 27, 2024 06:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@harshachinta harshachinta harshachinta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[spanner_dbapi] While running a query that contains just comment, it causes an IndexError exception

3 participants

@bhatt4982 @harshachinta @yoshi-kokoro