This repository was archived by the owner on Mar 31, 2026. It is now read-only.
chore(spanner): Issue591# cursor.list tables() is returning views#1162
Merged
harshachinta merged 13 commits intogoogleapis:mainfrom Aug 5, 2024
bhatt4982:Issue591#-cursor.list_tables()-is-returning-views
Merged
chore(spanner): Issue591# cursor.list tables() is returning views#1162harshachinta merged 13 commits intogoogleapis:mainfrom bhatt4982:Issue591#-cursor.list_tables()-is-returning-views
harshachinta merged 13 commits intogoogleapis:mainfrom
bhatt4982:Issue591#-cursor.list_tables()-is-returning-views
Conversation
…rg include_views - cursor.list_tables() return table and views by default - added another variable include_view - returns tables and views if include_view is set to True(default) - returns tables only if include_view is set to False - kept default value to True otherwise it will break any existing script
… - add arg include_views" This reverts commit e898d4ea0a69464d38f8c4d5c461a858558bd41b.
…well - cursor.list_tables() returns table and views by default - added parameter include_views with default to True - If include_views is false, cursor.list_tables() would return only tables(table_type = 'BASE TABLE')
harshachinta
approved these changes
Jul 29, 2024
Contributor
|
@bhatt4982 |
- fix lint failure
…s-returning-views' into Issue591#-cursor.list_tables()-is-returning-views
- Fixed unit test
…s-returning-views' into Issue591#-cursor.list_tables()-is-returning-views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(spanner): Issue591# cursor.list_tables() is returning views as well
Fixes cursor.list_tables() is returning views as well #591 🦕