This repository was archived by the owner on Mar 2, 2026. It is now read-only.
fix: move to using insecure grpc channels with emulator#402
Merged
crwilcox merged 13 commits intogoogleapis:masterfrom Jul 22, 2021
Merged
fix: move to using insecure grpc channels with emulator#402crwilcox merged 13 commits intogoogleapis:masterfrom
crwilcox merged 13 commits intogoogleapis:masterfrom
Conversation
tseaver
reviewed
Jul 21, 2021
craiglabenz
reviewed
Jul 21, 2021
| return grpc.aio.secure_channel( | ||
| self._emulator_host, self._local_composite_credentials() | ||
| ) | ||
| return grpc.aio.insecure_channel(self._emulator_host) |
Contributor
There was a problem hiding this comment.
Can we possibly have our cake and eat it too by introducing another environment variable for these custom credentials?
Contributor
Author
|
@paulharter FYI. This should still support your use case, but as there was no test added to demonstrate your complete use, I am unsure. Reach out if this doesn't work and we can find a way to support both use case :) |
8064453 to
b2af8b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #359
On windows, configuring a secure channel with credentials will not connect.