Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

fix(samples): catch EOFError in quickstart#708

Merged
Linchin merged 1 commit intogoogleapis:mainfrom
Linchin:eoferror
Nov 17, 2023
Merged

fix(samples): catch EOFError in quickstart#708
Linchin merged 1 commit intogoogleapis:mainfrom
Linchin:eoferror

Conversation

@Linchin
Copy link
Copy Markdown
Contributor

@Linchin Linchin commented Nov 15, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #707 🦕

@Linchin Linchin requested a review from shollyman November 15, 2023 19:22
@Linchin Linchin requested a review from a team as a code owner November 15, 2023 19:22
@Linchin Linchin requested review from a team and vchudnov-g November 15, 2023 19:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. labels Nov 15, 2023
@Linchin Linchin requested review from chalmerlowe and removed request for vchudnov-g November 16, 2023 18:52
@Linchin Linchin merged commit 1683879 into googleapis:main Nov 17, 2023
@release-please release-please bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Samples continuous tests failing due to fastavro upgrade

2 participants

@Linchin @shollyman