This repository was archived by the owner on Mar 16, 2026. It is now read-only.
fix: Adds keyword argument to test due to changes in sqlalchemy alembic#868
Merged
chalmerlowe merged 1 commit intomainfrom May 31, 2023
Merged
fix: Adds keyword argument to test due to changes in sqlalchemy alembic#868chalmerlowe merged 1 commit intomainfrom
chalmerlowe merged 1 commit intomainfrom
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
rsamborski
approved these changes
May 31, 2023
m-strzelczyk
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlalchemy-alembicchanged the function signature for a number of functions:They added an asterisk (
*) into the function signature to separate positional arguments from keyword arguments.This has the downstream effect of requiring keyword arguments to be spelled out when calling them within the function. This affected one of our tests, since none of the other tests specifically used any keyword arguments.
Based on a check through the code for other uses of functions from alembic, none of our other uses of the functions in either the body of the code OR in our tests appears to be impacted by the upstream change.
Fixes #862 🦕