Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: skip test_to_dataframe_iterable_w_bqstorage_max_results_warning if google-cloud-bigquery-storage is not installed#1814

Merged
Linchin merged 1 commit intomainfrom
b319116851-bqstorage-test-skip
Feb 8, 2024
Merged

chore: skip test_to_dataframe_iterable_w_bqstorage_max_results_warning if google-cloud-bigquery-storage is not installed#1814
Linchin merged 1 commit intomainfrom
b319116851-bqstorage-test-skip

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Feb 8, 2024

We don't currently have any nox sessions where pandas is installed but google-cloud-bigquery-storage is not, but I encountered this when pulling google-cloud-bigquery update into the internal google repository.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 319116851.
🦕

…ng` if google-cloud-bigquery-storage is not installed
@tswast tswast requested review from a team and chalmerlowe February 8, 2024 15:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 8, 2024
@tswast tswast requested a review from parthea February 8, 2024 18:47
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Feb 8, 2024

Requesting review from @Linchin

@Linchin
Copy link
Copy Markdown
Contributor

Linchin commented Feb 8, 2024

Thank you! :)

@Linchin Linchin merged commit 57be031 into main Feb 8, 2024
@Linchin Linchin deleted the b319116851-bqstorage-test-skip branch February 8, 2024 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants