Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

refactor: refactored _get_final_span_attributes() for clarity, simplicity#1602

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
get-final-span-attr-refactor
Jun 29, 2023
Merged

refactor: refactored _get_final_span_attributes() for clarity, simplicity#1602
gcf-merge-on-green[bot] merged 2 commits intomainfrom
get-final-span-attr-refactor

Conversation

@chalmerlowe
Copy link
Copy Markdown
Collaborator

Refactors the _get_final_span_attributes() function for simplicity and clarity.

  • adds docstring
  • removes several lines of redundant/unnecessary code
  • renames temporary variable for clarity

@chalmerlowe chalmerlowe requested review from a team and shollyman June 29, 2023 11:41
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented Jun 29, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jun 29, 2023
@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3fbe371 into main Jun 29, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the get-final-span-attr-refactor branch June 29, 2023 15:26
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants