Skip to content

feat: Migrate sample and sample tests - Batch 1 of 5#11

Merged
vinnysenthil merged 18 commits intosample-final-stagefrom
sample-staging-1
Nov 2, 2020
Merged

feat: Migrate sample and sample tests - Batch 1 of 5#11
vinnysenthil merged 18 commits intosample-final-stagefrom
sample-staging-1

Conversation

@vinnysenthil
Copy link
Copy Markdown
Contributor

@vinnysenthil vinnysenthil commented Sep 25, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 1 of 5) 🦕

@vinnysenthil vinnysenthil requested review from a team and dizcology as code owners September 25, 2020 21:57
@vinnysenthil vinnysenthil requested review from tmatsuo and removed request for a team September 25, 2020 21:57
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@release-please release-please bot requested a review from a team as a code owner September 25, 2020 23:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2020
@dizcology dizcology added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 28, 2020
@vinnysenthil vinnysenthil changed the base branch from release-v0.2.0 to master September 29, 2020 17:32
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@vinnysenthil vinnysenthil added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2020
@vinnysenthil vinnysenthil changed the base branch from master to sample-final-stage September 30, 2020 23:39
@vinnysenthil vinnysenthil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 30, 2020
tmatsuo
tmatsuo suggested changes Oct 2, 2020
View reviewed changes
vinnysenthil added a commit that referenced this pull request Oct 9, 2020
@vinnysenthil
Add pytest to requirements.txt from PR #11
4642de1
@vinnysenthil vinnysenthil requested a review from tmatsuo October 29, 2020 18:55
tmatsuo
tmatsuo reviewed Oct 29, 2020
View reviewed changes
@vinnysenthil vinnysenthil requested a review from tmatsuo October 30, 2020 00:52
tmatsuo
tmatsuo reviewed Nov 2, 2020
View reviewed changes
Copy link
Copy Markdown

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see one split without asserting.

tmatsuo
tmatsuo reviewed Nov 2, 2020
View reviewed changes
Copy link
Copy Markdown

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests are failing.
Maybe you can just put the test files in the same directory as the samples?

@vinnysenthil
Copy link
Copy Markdown
Contributor Author

vinnysenthil commented Nov 2, 2020

@tmatsuo - Added that last assertion.

The test have dependencies on samples in other batch PRs. The tests will successfully run before we merge the sample-final-stage -> master PR.

@vinnysenthil vinnysenthil requested a review from tmatsuo November 2, 2020 18:14
tmatsuo
tmatsuo reviewed Nov 2, 2020
View reviewed changes
Copy link
Copy Markdown

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll make the final approval when we see the tests are passing!

@vinnysenthil vinnysenthil merged commit c37c8ef into sample-final-stage Nov 2, 2020
@vinnysenthil vinnysenthil mentioned this pull request Nov 2, 2020
Merged
4 tasks
@vinnysenthil vinnysenthil deleted the sample-staging-1 branch December 3, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizcology dizcology Awaiting requested review from dizcology

1 more reviewer

@tmatsuo tmatsuo tmatsuo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add samples and sample tests

5 participants

@vinnysenthil @tmatsuo @dizcology @yoshi-kokoro @busunkim96