This repository was archived by the owner on Oct 31, 2025. It is now read-only.
fix: keep nano second precision when maps between JSON and proto3#28
Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom Jan 14, 2022
Merged
fix: keep nano second precision when maps between JSON and proto3#28gcf-merge-on-green[bot] merged 4 commits intomainfrom
gcf-merge-on-green[bot] merged 4 commits intomainfrom
Conversation
alexander-fenster
approved these changes
Jan 14, 2022
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
Approved with some style / simplification suggestions, please feel free to merge after you resolve. Thank you!
Contributor
Author
Addressed all the comments. It's good to know the method |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
|
Warning: This pull request is touching the following templated files:
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
🤖 I have created a release *beep* *boop* --- ### [0.1.7](v0.1.6...v0.1.7) (2022-01-14) ### Bug Fixes * keep nano second precision when maps between JSON and proto3 ([#28](#28)) ([eaa01ce](eaa01ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa
pushed a commit
to googleapis/google-cloud-node-core
that referenced
this pull request
Oct 1, 2025
🤖 I have created a release *beep* *boop* --- ### [0.1.7](googleapis/proto3-json-serializer-nodejs@v0.1.6...v0.1.7) (2022-01-14) ### Bug Fixes * keep nano second precision when maps between JSON and proto3 ([#28](googleapis/proto3-json-serializer-nodejs#28)) ([eaa01ce](googleapis/proto3-json-serializer-nodejs@eaa01ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa
pushed a commit
to googleapis/google-cloud-node-core
that referenced
this pull request
Oct 9, 2025
🤖 I have created a release *beep* *boop* --- ### [0.1.7](googleapis/proto3-json-serializer-nodejs@v0.1.6...v0.1.7) (2022-01-14) ### Bug Fixes * keep nano second precision when maps between JSON and proto3 ([#28](googleapis/proto3-json-serializer-nodejs#28)) ([eaa01ce](googleapis/proto3-json-serializer-nodejs@eaa01ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fractional seconds in the JSON timestamps can go up to 9 digits (i.e. up to 1 nanosecond resolution). timestamps.proto
However, Javascript Date object represent any date and time to millisecond precision.
To keep the precision, we extract the fractional seconds and append 0 until the length is equal to 9.