Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: resolve issue where marshal fails with cross api dependency#348

Merged
parthea merged 3 commits intomainfrom
fix-cross-api-dependency
Jun 12, 2023
Merged

fix: resolve issue where marshal fails with cross api dependency#348
parthea merged 3 commits intomainfrom
fix-cross-api-dependency

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Mar 7, 2023

Fixes #349
Fixes googleapis/python-gke-hub#151
Googlers see go/proto-plus-cross-api-issue

@parthea parthea force-pushed the fix-cross-api-dependency branch from aed6ea9 to e123ad8 Compare March 15, 2023 12:00
@parthea parthea changed the title [WIP] fix: resolve issue where marshal fails with cross api dependency fix: resolve issue where marshal fails with cross api dependency Mar 15, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2023
@parthea parthea force-pushed the fix-cross-api-dependency branch from 7a921ea to 0df6e02 Compare March 15, 2023 12:24
@parthea parthea marked this pull request as ready for review March 15, 2023 12:25
@parthea parthea requested review from a team March 15, 2023 12:25
@parthea parthea force-pushed the fix-cross-api-dependency branch from 0df6e02 to 8f6b7b5 Compare March 15, 2023 12:26
@parthea parthea added the status: blocked Resolving the issue is dependent on other work. label Mar 16, 2023
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Mar 16, 2023

Waiting for approval on go/proto-plus-cross-api-issue

Copy link
Copy Markdown
Contributor

@atulep atulep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea enabled auto-merge (squash) June 12, 2023 17:21
@parthea parthea merged commit 0dcea18 into main Jun 12, 2023
@parthea parthea deleted the fix-cross-api-dependency branch June 12, 2023 17:22
This was referenced Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marshal fails with TypeError when using cross api message Unable to configure config management with Clusters registered with Anthos

3 participants