This repository was archived by the owner on Jan 18, 2025. It is now read-only.
Re-enabling disabled slow tests. #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes googleapis#85. Whatever issue was causing the slowdown was related to the Py3k string/unicode issues. I'd guess it was in the crypto paths where an expensive computation was being done for no reason. Running them without network (to make sure mocks are correct): - `py26openssl13` - Ran 152 tests in 6.163s - `py26openssl14` - Ran 152 tests in 6.878s - `py27openssl13` - Ran 152 tests in 4.657s - `py27openssl14` - Ran 152 tests in 5.651s - `py33openssl14` - Ran 152 tests in 6.685s - `py34openssl14` - Ran 152 tests in 6.373s - `pypyopenssl13` - Ran 152 tests in 4.932s - `pypyopenssl14` - Ran 152 tests in 5.699s
craigcitro
added a commit
that referenced
this pull request
Dec 9, 2014
Re-enabling disabled slow tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85.
Whatever issue was causing the slowdown was related to the
Py3k string/unicode issues. I'd guess it was in the crypto paths
where an expensive computation was being done for no reason.
Running them without network (to make sure mocks are correct):
py26openssl13- Ran 152 tests in 6.163spy26openssl14- Ran 152 tests in 6.878spy27openssl13- Ran 152 tests in 4.657spy27openssl14- Ran 152 tests in 5.651spy33openssl14- Ran 152 tests in 6.685spy34openssl14- Ran 152 tests in 6.373spypyopenssl13- Ran 152 tests in 4.932spypyopenssl14- Ran 152 tests in 5.699s