Skip to content

fix: use storage.googleapis.com for api endpoint #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 1 commit into from
Sep 17, 2019
Merged

fix: use storage.googleapis.com for api endpoint #854

stephenplusplus merged 1 commit into from
Sep 17, 2019

Conversation

@JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Sep 17, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2019
frankyn
frankyn approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2019
@stephenplusplus stephenplusplus merged commit 27fa02f into master Sep 17, 2019
@stephenplusplus stephenplusplus deleted the domain branch September 17, 2019 15:56
frankyn added a commit that referenced this pull request Oct 21, 2019
@frankyn
Revert "fix: use storage.googleapis.com for api endpoint (#854)"
8c034de 
This reverts commit 27fa02f.
@frankyn frankyn mentioned this pull request Oct 21, 2019
Merged
frankyn added a commit that referenced this pull request Oct 21, 2019
@frankyn
Revert "fix: use storage.googleapis.com for api endpoint (#854)" (#893)
2ddff58 
This reverts commit 27fa02f.
frankyn added a commit that referenced this pull request Oct 24, 2019
@frankyn
Revert "Revert "fix: use storage.googleapis.com for api endpoint (#854)…
a36987a 
…" (#893)"

This reverts commit 2ddff58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JustinBeckwith @stephenplusplus @frankyn @googlebot @kokoro-team