Skip to content

revert: remove unsupported keepAcl param from file#copy #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkwlui merged 2 commits into from
Aug 30, 2019
Merged

revert: remove unsupported keepAcl param from file#copy #837

jkwlui merged 2 commits into from
Aug 30, 2019

Conversation

@AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Aug 28, 2019

Fixes #836

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
@AVaksman AVaksman mentioned this pull request Aug 28, 2019
Closed
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019
@AVaksman AVaksman changed the title docs: remove unsupported keepAcl param docs: remove unsupported keepAcl param from file#copy Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019 •
edited
Loading

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          11       11           
  Lines        1194     1194           
  Branches      296      296           
=======================================
  Hits         1137     1137           
  Misses         29       29           
  Partials       28       28
Impacted Files Coverage Δ
src/file.ts 98.12% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f6a9f...e0f5bda. Read the comment docs.

@callmehiphop
Copy link
Contributor

callmehiphop commented Aug 28, 2019

I might be wrong, but this looks like a TypeScript breaking change?

@AVaksman
Copy link
Contributor Author

AVaksman commented Aug 29, 2019

I might be wrong, but this looks like a TypeScript breaking change?

#165 (comment)

@callmehiphop
Copy link
Contributor

callmehiphop commented Aug 29, 2019

I see, maybe the commit title should be revert instead of docs then.

@AVaksman AVaksman changed the title docs: remove unsupported keepAcl param from file#copy revert: remove unsupported keepAcl param from file#copy Aug 29, 2019
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Aug 30, 2019

Sorry, Internet :(

@jkwlui jkwlui merged commit 5f69a3d into googleapis:master Aug 30, 2019
AVaksman added a commit to AVaksman/nodejs-storage that referenced this pull request Sep 5, 2019
@AVaksman
Revert "fix: remove unsupported keepAcl param (googleapis#837)"
85dc796 
This reverts commit 5f69a3d.
@AVaksman AVaksman deleted the remove_unsuperted_param branch September 26, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@callmehiphop callmehiphop callmehiphop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doc outdated: option "keepAcl" in file#copy is not in action

6 participants

@AVaksman @callmehiphop @stephenplusplus @jkwlui @googlebot @kokoro-team