Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

test: handle multiple possibilities in HNS tests#2467

Merged
ddelgrosso1 merged 1 commit into
googleapis:mainfrom
ddelgrosso1:adjust-hns-test
May 13, 2024
Merged

test: handle multiple possibilities in HNS tests#2467
ddelgrosso1 merged 1 commit into
googleapis:mainfrom
ddelgrosso1:adjust-hns-test

Conversation

@ddelgrosso1

@ddelgrosso1 ddelgrosso1 commented May 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2463 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team May 13, 2024 13:46
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 13, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 13, 2024
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2024
@ddelgrosso1 ddelgrosso1 merged commit 75940e3 into googleapis:main May 13, 2024
@ddelgrosso1 ddelgrosso1 deleted the adjust-hns-test branch May 13, 2024 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielduhh danielduhh danielduhh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage bucket hierarchical namespace: should create a bucket without hierarchical namespace enabled (explicit) failed

3 participants

@ddelgrosso1 @danielduhh @yoshi-kokoro