Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: file preconditions should respect ifGenerationMatch not ifMetage…#1642

Merged
shaffeeullah merged 1 commit into
googleapis:mainfrom
ddelgrosso1:fix-file-meta
Oct 6, 2021
Merged

fix: file preconditions should respect ifGenerationMatch not ifMetage…#1642
shaffeeullah merged 1 commit into
googleapis:mainfrom
ddelgrosso1:fix-file-meta

Conversation

@ddelgrosso1

@ddelgrosso1 ddelgrosso1 commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

…nerationMatch

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team October 6, 2021 17:53
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 6, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 6, 2021
shaffeeullah
shaffeeullah approved these changes Oct 6, 2021
View reviewed changes

@shaffeeullah shaffeeullah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks denis!

@shaffeeullah shaffeeullah merged commit eb6f31f into googleapis:main Oct 6, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 6, 2021
@release-please
chore: release 5.14.7 (#1643)
abdf6d9 
🤖 I have created a release \*beep\* \*boop\*
---
### [5.14.7](https://www.github.com/googleapis/nodejs-storage/compare/v5.14.6...v5.14.7) (2021-10-06)


### Bug Fixes

* file preconditions should respect ifGenerationMatch not ifMetagenerationMatch ([#1642](https://www.github.com/googleapis/nodejs-storage/issues/1642)) ([eb6f31f](https://www.github.com/googleapis/nodejs-storage/commit/eb6f31f3f6c439e21bbc0cd46f32a7327e15f65e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@danielbankhead danielbankhead mentioned this pull request Oct 14, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelgrosso1 @shaffeeullah