This repository was archived by the owner on Mar 4, 2026. It is now read-only.
feat: Support For Proto Column in Spanner#1829
Merged
surbhigarg92 merged 20 commits intogoogleapis:proto-column-enhancement-alphafrom Aug 7, 2023
Merged
Conversation
Changes need to be reverted.
-Adding Logic for Serialization & Deserialization -New Type Codes and utilities
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
vaibhavagarwal220
approved these changes
Apr 1, 2023
asthamohta
reviewed
Apr 13, 2023
asthamohta
reviewed
Apr 13, 2023
asthamohta
reviewed
Apr 13, 2023
asthamohta
reviewed
Apr 13, 2023
asthamohta
reviewed
Apr 13, 2023
asthamohta
reviewed
Apr 13, 2023
asthamohta
reviewed
Apr 17, 2023
surbhigarg92
approved these changes
May 2, 2023
asthamohta
approved these changes
May 5, 2023
olavloite
reviewed
May 10, 2023
skuruppu
suggested changes
May 10, 2023
Contributor
skuruppu
left a comment
There was a problem hiding this comment.
I only ended up reviewing the src/ files for now. Once we discuss the comments, I'm happy to look into tests and samples.
src/codec.ts
Outdated
| ).finish(); | ||
| } else { | ||
| throw new GoogleError(`protoMessageParams cannot be used for constructing ProtoMessage. | ||
| Please pass serializedBytes as value or message object with messageFunction`); |
Contributor
There was a problem hiding this comment.
I don't know what serializedBytes is. Is it a type?
Contributor
Author
There was a problem hiding this comment.
By serializedBytes I meant serialized buffer of the proto message. Thank you for flagging it out, updating the exception message.
protoMessageParams cannot be used to construct the ProtoMessage. Pass the serialized buffer of the proto-message as the value or provide the message object along with the corresponding messageFunction generated by protobufjs-cli.
olavloite
reviewed
Jul 20, 2023
olavloite
reviewed
Jul 25, 2023
olavloite
approved these changes
Jul 25, 2023
harshachinta
added a commit
that referenced
this pull request
May 15, 2024
* feat: Support For Proto Column in Spanner (#1829) * feat: Generated Proto Changes Changes need to be reverted. * feat: Implementation for Proto Message & Enum -Adding Logic for Serialization & Deserialization -New Type Codes and utilities * feat: Proto static files and typings and generated descriptors * sample: Adding DML, DQL, DML, table insert & read samples. * style: Lint * test: Adding unit tests * refactor: minor refactoring * refactor: minor refactoring * test: Adding integration tests * docs: Adding docs * test: Adding sample Integration Tests * refactor: Minor refactoring and updating comments/docs. * test: Making test fixes * refactor: Minor refactoring and lint fixes * refactor: Minor refactoring and lint fixes * Updating docs and minor changes. * test: fixing test * refactor: minor changes * refactor: minor refactoring * docs: Updating docs & comments * feat(spanner): fix lint * fix(spanner: lint * fix(spanner): lint * fix(spanner): lint * fix(spanner): lint * feat(spanner): fix db name * feat(spanner): remove it.only * feat(spanner): fix tests lint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(spanner): remove samples and sample tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(spanner): update schema to avoid reserved keyword * feat(spanner): add samples and sample tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(spanner): code refactoring --------- Co-authored-by: Gaurav Purohit <purohitgaurav0612@gmail.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Includes