Skip to content

fix: for merging when array/struct chunks contain null #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asthamohta merged 6 commits into from
Jan 19, 2022
Merged

fix: for merging when array/struct chunks contain null #1541

asthamohta merged 6 commits into from
Jan 19, 2022

Conversation

@asthamohta
Copy link
Contributor

@asthamohta asthamohta commented Jan 17, 2022

fix for issue #1539

@asthamohta asthamohta requested review from a team as code owners January 17, 2022 12:22
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 17, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
asthamohta and others added 4 commits January 19, 2022 02:38
@asthamohta
fix: for merging when array/struct chunks contain null
6e4b938
@asthamohta @gcf-owl-bot
fix: fix for new @types/node version (googleapis#1542)
f9bd94d 
* fix: fix for new @types/node version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please @asthamohta
chore(main): release 5.16.2 (googleapis#1543)
f699984 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@asthamohta
fix: adding test case for chunked struct with a null array
1be1b70
@asthamohta asthamohta force-pushed the fixForPartialResultSet branch from 9df557d to 1be1b70 Compare January 18, 2022 21:08
@asthamohta asthamohta linked an issue Jan 18, 2022 that may be closed by this pull request
TypeError: Cannot read property 'pop' of null #1539
Closed
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@asthamohta asthamohta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@asthamohta asthamohta added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 18, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 18, 2022
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2022
@asthamohta asthamohta added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 19, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 19, 2022
@asthamohta asthamohta merged commit 72871fc into googleapis:main Jan 19, 2022
@release-please release-please bot mentioned this pull request Jan 19, 2022
Merged
asthamohta added a commit to asthamohta/nodejs-spanner that referenced this pull request Jan 19, 2022
@asthamohta @gcf-owl-bot @release-please
fix: for merging when array/struct chunks contain null (googleapis#1541)
b2801ae 
* fix: for merging when array/struct chunks contain null

* fix: fix for new @types/node version (googleapis#1542)

* fix: fix for new @types/node version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 5.16.2 (googleapis#1543)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: adding test case for chunked struct with a null array

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
asthamohta added a commit that referenced this pull request Jan 19, 2022
@asthamohta @gcf-owl-bot @release-please
chore: changing region to west1 for samples (#1549)
9bdd28a 
* chore: changing region

* test(nodejs): remove 15 add 16 (#1322) (#1531)

* fix: for merging when array/struct chunks contain null (#1541)

* fix: for merging when array/struct chunks contain null

* fix: fix for new @types/node version (#1542)

* fix: fix for new @types/node version

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 5.16.2 (#1543)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: adding test case for chunked struct with a null array

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
gcf-owl-bot bot added a commit that referenced this pull request Aug 24, 2022
@gcf-owl-bot
fix: add hashes to requirements.txt (#1544)
e8a7cc2 
* fix: add hashes to requirements.txt

and update Docker images so they require hashes.

* fix: add hashes to docker/owlbot/java/src

* Squashed commit of the following:

commit ab7384ea1c30df8ec2e175566ef2508e6c3a2acb
Author: Jeffrey Rennie <rennie@google.com>
Date:   Tue Aug 23 11:38:48 2022 -0700

    fix: remove pip install statements (#1546)

    because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227

commit 302667c9ab7210da42cc337e8f39fe1ea99049ef
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Tue Aug 23 19:50:28 2022 +0200

    chore(deps): update dependency setuptools to v65.2.0 (#1541)

    Co-authored-by: Anthonios Partheniou <partheniou@google.com>

commit 6e9054fd91d1b500cae58ff72ee9aeb626077756
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Tue Aug 23 19:42:51 2022 +0200

    chore(deps): update dependency nbconvert to v7 (#1543)

    Co-authored-by: Anthonios Partheniou <partheniou@google.com>

commit d229a1258999f599a90a9b674a1c5541e00db588
Author: Alexander Fenster <fenster@google.com>
Date:   Mon Aug 22 15:04:53 2022 -0700

    fix: update google-gax and remove obsolete deps (#1545)

commit 13ce62621e70059b2f5e3a7bade735f91c53339c
Author: Jeffrey Rennie <rennie@google.com>
Date:   Mon Aug 22 11:08:21 2022 -0700

    chore: remove release config and script (#1540)

    We don't release to pypi anymore.

* chore: rollback java changes

to move forward with other languages until Java's docker image is fixed
Source-Link: googleapis/synthtool@4826337
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:7fefeb9e517db2dd8c8202d9239ff6788d6852bc92dd3aac57a46059679ac9de
asthamohta pushed a commit that referenced this pull request Aug 26, 2022
@gcf-owl-bot
fix: add hashes to requirements.txt (#1544) (#1697)
61a1468 
* fix: add hashes to requirements.txt

and update Docker images so they require hashes.

* fix: add hashes to docker/owlbot/java/src

* Squashed commit of the following:

commit ab7384ea1c30df8ec2e175566ef2508e6c3a2acb
Author: Jeffrey Rennie <rennie@google.com>
Date:   Tue Aug 23 11:38:48 2022 -0700

    fix: remove pip install statements (#1546)

    because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227

commit 302667c9ab7210da42cc337e8f39fe1ea99049ef
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Tue Aug 23 19:50:28 2022 +0200

    chore(deps): update dependency setuptools to v65.2.0 (#1541)

    Co-authored-by: Anthonios Partheniou <partheniou@google.com>

commit 6e9054fd91d1b500cae58ff72ee9aeb626077756
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Tue Aug 23 19:42:51 2022 +0200

    chore(deps): update dependency nbconvert to v7 (#1543)

    Co-authored-by: Anthonios Partheniou <partheniou@google.com>

commit d229a1258999f599a90a9b674a1c5541e00db588
Author: Alexander Fenster <fenster@google.com>
Date:   Mon Aug 22 15:04:53 2022 -0700

    fix: update google-gax and remove obsolete deps (#1545)

commit 13ce62621e70059b2f5e3a7bade735f91c53339c
Author: Jeffrey Rennie <rennie@google.com>
Date:   Mon Aug 22 11:08:21 2022 -0700

    chore: remove release config and script (#1540)

    We don't release to pypi anymore.

* chore: rollback java changes

to move forward with other languages until Java's docker image is fixed
Source-Link: googleapis/synthtool@4826337
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:7fefeb9e517db2dd8c8202d9239ff6788d6852bc92dd3aac57a46059679ac9de

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

@steffnay steffnay steffnay approved these changes

@vi3k6i5 vi3k6i5 Awaiting requested review from vi3k6i5

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'pop' of null

4 participants

@asthamohta @olavloite @steffnay @yoshi-kokoro