Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

docs(samples): add auto-generated samples for Node with api short name in region tag#1484

Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom
owl-bot-da7a570d-28e9-4f40-a109-a482d041834a
Nov 23, 2021
Merged

docs(samples): add auto-generated samples for Node with api short name in region tag#1484
gcf-merge-on-green[bot] merged 6 commits intomainfrom
owl-bot-da7a570d-28e9-4f40-a109-a482d041834a

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 27, 2021

  • Regenerate this pull request now.

PiperOrigin-RevId: 399287285

Source-Link: googleapis/googleapis@1575986

Source-Link: https://github.com/googleapis/googleapis-gen/commit/b27fff623a5d8d586b703b5e4919856abe7c2eb3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjI3ZmZmNjIzYTVkOGQ1ODZiNzAzYjVlNDkxOTg1NmFiZTdjMmViMyJ9

@gcf-owl-bot gcf-owl-bot bot requested review from a team September 27, 2021 22:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 27, 2021
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Sep 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2021
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Sep 27, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2021
@SurferJeffAtGoogle
Copy link
Copy Markdown
Contributor

Obsolete by #1489.

@fhinkel
Copy link
Copy Markdown
Contributor

fhinkel commented Nov 16, 2021

Spanner is half handwritten and half generated. The generated samples should be added for the generated sources.

@fhinkel fhinkel reopened this Nov 16, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 16, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 16, 2021
@skuruppu
Copy link
Copy Markdown
Contributor

skuruppu commented Nov 18, 2021

@fhinkel I'm happy to approve this but there are lots of lint failures. Could the generator be updated to comply with the lint checks?

gcf-owl-bot bot and others added 3 commits November 22, 2021 16:44
@bcoe bcoe force-pushed the owl-bot-da7a570d-28e9-4f40-a109-a482d041834a branch from 1f0c8c6 to 27b8a34 Compare November 22, 2021 17:14
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@fhinkel
Copy link
Copy Markdown
Contributor

fhinkel commented Nov 23, 2021

@skuruppu Looks like the lint problems got fixed 🥳 .

@fhinkel fhinkel added automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8a3e1f4 into main Nov 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-da7a570d-28e9-4f40-a109-a482d041834a branch November 23, 2021 17:00
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants