feat: add a close() method to PubSub, and a flush() method to Topic/Publisher #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like there's an issue in checkout@v1, and we hadn't updated all of the CI actions to v2. |
6e0f492 to
54b6ab0
Compare
bcoe
approved these changes
Mar 25, 2020
bcoe
left a comment
There was a problem hiding this comment.
This looks reasonable to me, not seeing any possums.
| ); | ||
| const allPublishes = Promise.all(publishes); | ||
|
|
||
| allPublishes |
There was a problem hiding this comment.
any reason not to use async/await here? I'm at the point where I pretty much always favor it these days.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I about 350% agree... unfortunately the current code is mostly callback-based, and a few event-based bits, so pulling the async/await far up the stack was looking difficult. I'd really like to go back and do a pass of just converting everything to straightforward async/await/Promises, but I don't want to do that as part of this.
| const definedCallback = callback || (() => {}); | ||
| if (this.isOpen) { | ||
| this.closeAllClients_() | ||
| .then(() => { |
There was a problem hiding this comment.
same comment, as above. I can understand the argument for keeping the codebase internally consistent, if that's the thinking.
Closed
Collaborator
Author
|
I added a note about the potentially flaky test, re-running Kokoro for now. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 30, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-pubsub/compare/v1.6.0...v1.7.0) (2020-03-29) ### Features * add a close() method to PubSub, and a flush() method to Topic/Publisher ([#916](https://www.github.com/googleapis/nodejs-pubsub/issues/916)) ([4097995](https://www.github.com/googleapis/nodejs-pubsub/commit/4097995a85a8ca3fb73c2c2a8cb0649cdd4274be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
…ublisher (#916) 4097995 commit 4097995 Author: Megan Potter <57276408+feywind@users.noreply.github.com> Date: Thu Mar 26 11:03:26 2020 -0700 feat: add a close() method to PubSub, and a flush() method to Topic/Publisher (#916) * docs: fix a typo in a comment * feat: allow manually closing the server connections in the PubSub object * feat: add flush() method for Topic objects * tests: add tests for new flush() and close() methods * build: update github checkout action to v2 to fix spurious retry errors * fix: set isOpen to false before trying to close it so that all usage will stop
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
b96eacf commit b96eacf Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Mon Mar 30 21:46:18 2020 +0000 chore: release 1.7.0 (#933) 🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/nodejs-pubsub/compare/v1.6.0...v1.7.0) (2020-03-29) ### Features * add a close() method to PubSub, and a flush() method to Topic/Publisher ([#916](https://www.github.com/googleapis/nodejs-pubsub/issues/916)) ([4097995](https://www.github.com/googleapis/nodejs-pubsub/commit/4097995a85a8ca3fb73c2c2a8cb0649cdd4274be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #817