Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

docs: fix publishMessage return type#1441

Merged
feywind merged 6 commits intogoogleapis:mainfrom
adi-hwn:main
Jan 21, 2022
Merged

docs: fix publishMessage return type#1441
feywind merged 6 commits intogoogleapis:mainfrom
adi-hwn:main

Conversation

@adi-hwn
Copy link
Copy Markdown
Contributor

@adi-hwn adi-hwn commented Dec 9, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1438 🦕

@adi-hwn adi-hwn requested review from a team December 9, 2021 21:20
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Dec 9, 2021
@adi-hwn adi-hwn force-pushed the main branch 4 times, most recently from 033cb82 to 71b7f84 Compare December 9, 2021 23:10
@adi-hwn adi-hwn changed the title fix publishMessage return type docs: fix publishMessage return type Dec 9, 2021
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2022
feywind
feywind approved these changes Jan 21, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 21, 2022
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 21, 2022
@feywind feywind merged commit e4b8adc into googleapis:main Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@feywind feywind feywind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typescript: publishMessage wrong response type

4 participants

@adi-hwn @feywind @yoshi-kokoro @meredithslota