fix(samples): Update synchronousPull to avoid INVALID_ARGUMENT error #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 26 26
Lines 12601 12601
Branches 559 608 +49
=======================================
Hits 12323 12323
Misses 273 273
Partials 5 5 Continue to review full report at Codecov.
|
Collaborator
|
@psilospore Thanks, this looks good! |
feywind
approved these changes
Jan 28, 2021
gcf-owl-bot bot
added a commit
that referenced
this pull request
Aug 25, 2021
Source-Link: googleapis/synthtool@31728d8 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:667a9e46a9aa5b80240ad164d55ac33bc9d6780b5ef42f125a41f0ad95bc1950
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
…will be rotated (googleapis#1194) * build: have Kokoro grab service account credentials from secret that will be rotated Source-Link: https://togithub.com/googleapis/synthtool/commit/4a0230eb8dc497f36fd3839e6144982131f30a9d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:f59941869d508c6825deeffce180579545fd528f359f549a80a18ec0458d7094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a copy-pasta and ended up getting this error:
3 INVALID_ARGUMENT: You have not specified an ack ID in the request.I have updated the example to check if any messages were received before sending an ack.
I can update any other examples if this checks out.
I know the template asks to make an issue but I thought this might be minor enough to just submit a PR. I can make one if you all would like.