Skip to content

Conversation

@laljikanjareeya
Copy link
Contributor

Fixes #1136

@laljikanjareeya laljikanjareeya requested review from a team as code owners October 26, 2020 09:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #1140 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   97.78%   97.81%   +0.02%     
==========================================
  Files          25       25              
  Lines       11067    11067              
  Branches      546      513      -33     
==========================================
+ Hits        10822    10825       +3     
+ Misses        241      238       -3     
  Partials        4        4              
Impacted Files Coverage Δ
src/v1/subscriber_client.ts 98.20% <0.00%> (+0.04%) ⬆️
src/v1/publisher_client.ts 97.75% <0.00%> (+0.05%) ⬆️
src/subscriber.ts 98.86% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ebdcd...3f5cffd. Read the comment docs.

@laljikanjareeya laljikanjareeya changed the title sample: apiEndpoint in publish order message sample docs(sample): regional endpoint in publish order message sample Oct 26, 2020
@laljikanjareeya laljikanjareeya changed the title docs(sample): regional endpoint in publish order message sample docs(sample): regional endpoint in publish ordered message sample Oct 26, 2020
@laljikanjareeya laljikanjareeya merged commit db1f69c into googleapis:master Oct 27, 2020
gcf-owl-bot bot added a commit that referenced this pull request Jun 25, 2021
Refs googleapis/nodejs-service-usage#22
Source-Link: googleapis/synthtool@6d26b13
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:e59b73e911585903ee6b8a1c5246e93d9e9463420f597b6eb2e4b616ee8a0fee
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 25, 2021
Refs googleapis/nodejs-service-usage#22
Source-Link: googleapis/synthtool@6d26b13
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:e59b73e911585903ee6b8a1c5246e93d9e9463420f597b6eb2e4b616ee8a0fee
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
…s#906)

Refs googleapis/nodejs-service-usage#22
Source-Link: googleapis/synthtool@6d26b13
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:e59b73e911585903ee6b8a1c5246e93d9e9463420f597b6eb2e4b616ee8a0fee
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227
Source-Link: googleapis/synthtool@ab7384e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

samples: publish ordering key sample doesn't specify regional endpoint

2 participants