test: fix error reporting system test race #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up.
ofrobots
added a commit
to ofrobots/nodejs-logging-winston
that referenced
this pull request
Mar 13, 2019
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Ref: googleapis/nodejs-logging-bunyan#275
Contributor
Author
|
I still do think that these error reporting system tests have been creating too much busy work and not providing real value. I do not think we have found a single legitimate failure in the past year+. I wouldn't mind if they were to go away. |
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 2 2
Lines 78 78
Branches 8 8
=======================================
Hits 74 74
Misses 4 4Continue to review full report at Codecov.
|
ofrobots
added a commit
to googleapis/nodejs-logging-winston
that referenced
this pull request
Mar 14, 2019
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Ref: googleapis/nodejs-logging-bunyan#275
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jan 14, 2026
The system tests for error reporting were still not safe to run concurrently. The issue is that at the end we were deleting all events (there is no API to delete events selectively, AFAICT). This meant that concurrent executions of the system tests against the same project could clobber anothers logged errors. This is consistent with the observed timeouts looking for events to show up. Ref: googleapis/nodejs-logging-bunyan#275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system tests for error reporting were still not safe to run
concurrently. The issue is that at the end we were deleting all events
(there is no API to delete events selectively, AFAICT). This meant that
concurrent executions of the system tests against the same project could
clobber anothers logged errors.
This is consistent with the observed timeouts looking for events to
show up.
Fixes #267