This repository was archived by the owner on Mar 4, 2026. It is now read-only.
feat: add support for regexFind and regexFindAll#2474
Merged
Conversation
MarkDuckworth
suggested changes
Jan 30, 2026
Contributor
MarkDuckworth
left a comment
There was a problem hiding this comment.
You will also need to update (types/firestore.d.ts)[https://github.com/googleapis/nodejs-firestore/blob/main/types/firestore.d.ts] with the types. It's an unfortunate side effect of the current structure of this repo, but shouldn't be too much work in this case.
MarkDuckworth
approved these changes
Jan 30, 2026
MarkDuckworth
approved these changes
Feb 2, 2026
dlarocque
added a commit
that referenced
this pull request
Feb 23, 2026
Follow up to #2474. The `regexFind` and `regexFindAll` standalone expression functions were not exported to the public API by mistake. This PR exports them to the public API and updates the import path in the tests.
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Feb 24, 2026
…2492) Follow up to googleapis/nodejs-firestore#2474. The `regexFind` and `regexFindAll` standalone expression functions were not exported to the public API by mistake. This PR exports them to the public API and updates the import path in the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
regexFindandregexFindAll. Most of this is copied from firebase/firebase-js-sdk#9454.