Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

Aggregations API proposal#1692

Closed
dconeybe wants to merge 2 commits intomainfrom
dconeybe/AggregateApi
Closed

Aggregations API proposal#1692
dconeybe wants to merge 2 commits intomainfrom
dconeybe/AggregateApi

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Mar 1, 2022

DO NOT MERGE - This PR is only created to get initial feedback. This PR will eventually be deleted.

@dconeybe dconeybe self-assigned this Mar 1, 2022
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Mar 1, 2022
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch 4 times, most recently from 1f48b7b to 72b3b06 Compare March 4, 2022 21:19
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch 4 times, most recently from 3197e4c to b413e9d Compare March 17, 2022 19:26
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from b413e9d to b5b070d Compare May 3, 2022 19:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 3, 2022
@dconeybe dconeybe changed the base branch from main to dconeybe/CountApi June 17, 2022 18:45
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from b5b070d to 7b2f027 Compare June 17, 2022 18:46
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 17, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@dconeybe dconeybe force-pushed the dconeybe/CountApi branch from 3232789 to 54f8953 Compare June 20, 2022 19:26
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from 7b2f027 to a835637 Compare June 20, 2022 19:27
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from a835637 to b5506c7 Compare September 13, 2022 15:40
@dconeybe dconeybe changed the base branch from dconeybe/CountApi to main October 22, 2022 03:51
gcf-owl-bot bot added a commit that referenced this pull request Mar 12, 2025
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)
fix: add json files to tsconfig templates (#1692) (ba6be1d)

PiperOrigin-RevId: 735896588

Source-Link: googleapis/googleapis@3419af7

Source-Link: googleapis/googleapis-gen@f35ba11
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
MarkDuckworth added a commit that referenced this pull request Dec 13, 2025
* chore: expose the Firestore.executePipeline API to the preview branch
docs: minor documentation updates to `StructuredQuery`
docs: minor documentation changes for `distance_threshold`

PiperOrigin-RevId: 731306872

Source-Link: googleapis/googleapis@b6d5ae8

Source-Link: googleapis/googleapis-gen@4cb9048
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNiOTA0ODg3MWJmNTkwNmIzOTBlOGVhM2Q3YjlmMWVmNmFjMTlkNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 731691059

Source-Link: googleapis/googleapis@7e5dd6b

Source-Link: googleapis/googleapis-gen@2b78e07
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmI3OGUwN2NkMmExZWIzN2ZiMDEwN2MyMGMxYjZkY2MzZjRjYjc0YiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 731693666

Source-Link: googleapis/googleapis@fd510f8

Source-Link: googleapis/googleapis-gen@42097f7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDIwOTdmN2NjNzZlZTdiZGZlY2FlYWVhMTE1YWYyMzU3MTZmZGRiMSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update typescript gapic generator to 4.8.1
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)
fix: add json files to tsconfig templates (#1692) (ba6be1d)

PiperOrigin-RevId: 735896588

Source-Link: googleapis/googleapis@3419af7

Source-Link: googleapis/googleapis-gen@f35ba11
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9

* feat: await/catch promises, and update listOperationsAsync return type

PiperOrigin-RevId: 738212310

Source-Link: googleapis/googleapis@803b234

Source-Link: googleapis/googleapis-gen@4f44bd2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9

* feat: add the UserCreds API

PiperOrigin-RevId: 742708704

Source-Link: googleapis/googleapis@35980b6

Source-Link: googleapis/googleapis-gen@23742c6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjM3NDJjNmRlZWNjODFkZTA1MjVkMmVlNzk4MGUyNThlNDNmZWU1YiJ9

* feat: new Firestore index modes and Database Editions

PiperOrigin-RevId: 745570206

Source-Link: googleapis/googleapis@4ec607b

Source-Link: googleapis/googleapis-gen@49fab77
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDlmYWI3NzhiNzA5ODg3MGY5OTFlYmRlOTFkYTVmOTI2ZjQwNmZkNSJ9

* chore: upgrade typescript generator to 4.9.0
chore: updated gapic-generator-typescript WORKSPACE section to match the latest from the generator
chore: added Required Typecheck Performance Selection section to .bazelrc
feat: add protobufjs 2023 edition support
feat: selective gapic support for typescript generation
fix: catch dangling promises

PiperOrigin-RevId: 751558264

Source-Link: googleapis/googleapis@f132131

Source-Link: googleapis/googleapis-gen@7aaa93d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2FhYTkzZDlkNGJiZDBjODdhZGMxOGI0ZGMwMzg0Yjc4MzgwMGEzYiJ9

* feat: add methods from gax to cache proto root and process custom error details
fix: distinguish plural and singular path templates

PiperOrigin-RevId: 772168312

Source-Link: googleapis/googleapis@873d84e

Source-Link: googleapis/googleapis-gen@f448c1b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ0OGMxYjRlYWFhNWZkYzcwMjFhNjgyMDY4YzMxM2Q2ZjJmMTA0YSJ9

* feat: Expose tags field in Database and RestoreDatabaseRequest public protos

This change exposes the tags field in the Database and RestoreDatabaseRequest messages, allowing users to manage tags for Firestore databases.

PiperOrigin-RevId: 783460561

Source-Link: googleapis/googleapis@ba7105d

Source-Link: googleapis/googleapis-gen@5e034bb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWUwMzRiYjU1MTQ1ZTgxNGZkN2JhN2I0OWQ4YWYyOGJjMjBmYTY3OSJ9

* feat: add Firestore CloneDatabase support

PiperOrigin-RevId: 789807783

Source-Link: googleapis/googleapis@3d37c58

Source-Link: googleapis/googleapis-gen@66d3f2f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjZkM2YyZjNhYTU3ZDI0MjUzNGExZjM3MjZiNTk4ZjY0YmE2OWZjYiJ9

* chore: add top-level BUILD rule for new bundled generation process

PiperOrigin-RevId: 802243639

Source-Link: googleapis/googleapis@4a2d23d

Source-Link: googleapis/googleapis-gen@03d5b98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDNkNWI5ODBmZDkxMmY4ZTI4MWY4MTc3NDRhOWNlZjM1YWFmMzMzMCJ9

* chore: remove .md extension on LICENSE files

PiperOrigin-RevId: 802685533

Source-Link: googleapis/googleapis@0d129bf

Source-Link: googleapis/googleapis-gen@73664e2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzM2NjRlMjAwMjUzZGRiOGRlMmI5YmI5YzY1ZjZiNjgzMDExMDJmYiJ9

* chore: remove unneeded BAZEL import

PiperOrigin-RevId: 802775018

Source-Link: googleapis/googleapis@af3f926

Source-Link: googleapis/googleapis-gen@48e4634
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDhlNDYzNDQwZTk2M2MxNTUxM2VkMWM3NjY3NDk3NTU0NmY2ZGJhNiJ9

* chore: improve README and fix combined gapic rule generation
chore: request.id should be typecast to a string

PiperOrigin-RevId: 803577907

Source-Link: googleapis/googleapis@8f0f886

Source-Link: googleapis/googleapis-gen@6c5556d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmM1NTU2ZDA1YjllM2U0YmJlMWE3OGIzNmRhYTAxZjlhMzk4ZGVjMSJ9

* chore: update generator logic for nodejs_gapic_combined_pkg rule, and update templates

PiperOrigin-RevId: 808677883

Source-Link: googleapis/googleapis@a32846d

Source-Link: googleapis/googleapis-gen@593da26
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTkzZGEyNjUyZjJjNDNiNzY5ZGZlYjE5MTYxYTNiZTk1NWY5NzY3NCJ9

* chore: run compileProtos and update gapic-node-processing

PiperOrigin-RevId: 813843285

Source-Link: googleapis/googleapis@c61d80b

Source-Link: googleapis/googleapis-gen@e195618
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9

* chore: upgrade generator to upgrade gapic-node-processing dependency for system-test fix

PiperOrigin-RevId: 823157923

Source-Link: googleapis/googleapis@4f79c85

Source-Link: googleapis/googleapis-gen@e8fd3e6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZThmZDNlNmEyYmQ0YjFkYmM1ZGYyYTcxZGUzMDViNTc1Y2QzNmFmOSJ9

* docs: minor api documentation changes

PiperOrigin-RevId: 840398028

Source-Link: googleapis/googleapis@bfdeefc

Source-Link: googleapis/googleapis-gen@895eb7f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODk1ZWI3ZjM2NWRhNDBkNzE1ZWIzMDE3MTQwMzA4MWIwYjZlM2UwOSJ9

* feat: publish the pipelines API to the stable branch

PiperOrigin-RevId: 840829013

Source-Link: googleapis/googleapis@534adc5

Source-Link: googleapis/googleapis-gen@38e4d8b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzhlNGQ4YmY1Nzc0NDQyZGQ3Nzg5MzUxNTRmNWFlNTY1MzdmNTRlMiJ9

* chore: migrate generator to google-cloud-node
chore: update generator system tests

PiperOrigin-RevId: 841977762

Source-Link: googleapis/googleapis@c9578f6

Source-Link: googleapis/googleapis-gen@5a48994
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWE0ODk5NGZiZDg1MjRmNzM2YTI0MTc5YjgyODg2NjQ2NjlmMjQwMCJ9

* Add missing proto to update.sh

* Update eslint config to ignore errors in generated gapic tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Mark Duckworth <1124037+MarkDuckworth@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants