This repository was archived by the owner on Jul 13, 2023. It is now read-only.
tests: add GCE tests for diregapic #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
OK so for the enum values: can you use const Status = compute.protos.google.cloud.compute.v1.Operation.Status;
// then use Status.DONEAll values can be found in |
Codecov Report
@@ Coverage Diff @@
## diregapic #549 +/- ##
=============================================
- Coverage 97.17% 97.16% -0.01%
=============================================
Files 77 77
Lines 78901 78901
Branches 3810 3737 -73
=============================================
- Hits 76670 76666 -4
- Misses 2158 2162 +4
Partials 73 73
Continue to review full report at Codecov.
|
Contributor
|
To make lint pass: |
alexander-fenster
approved these changes
Apr 29, 2021
alexander-fenster
pushed a commit
that referenced
this pull request
Apr 29, 2021
* tests: add GCE tests for diregapic * tests: review fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕