Skip to content

Release v2.1.0 is not backward compatible #463

@jqll

Description

@jqll

Environment details

  • OS: Linux
  • @google-cloud/common version: v2.1.0

While compiling https://github.com/googleapis/cloud-profiler-nodejs, we see the error message:
Tue Aug 6 00:07:36 UTC 2019: ts/src/profiler.ts:444:9 - error TS2345: Argument of type '{ method: string; uri: string; body: { deployment: Deployment; profileType: string[]; }; json: boolean; timeout: number; }' is not assignable to parameter of type 'DecorateRequestOptions'.
Tue Aug 6 00:07:36 UTC 2019: Types of property 'method' are incompatible.
Tue Aug 6 00:07:36 UTC 2019: Type 'string' is not assignable to type '"GET" | "HEAD" | "POST" | "PUT" | "OPTIONS" | undefined'.

I believe #448 changed the interface for DecorateRequestOptions.method. Release v2.1.0 probably shouldn't be a minor release, as the change is not backward compatible.

Metadata

Metadata

Labels

TypeScripttype: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions