Skip to content

fix(deps): update to the latest version of teeny-request #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JustinBeckwith merged 1 commit into from
Aug 1, 2019
Merged

fix(deps): update to the latest version of teeny-request #448

JustinBeckwith merged 1 commit into from
Aug 1, 2019

Conversation

@JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jul 8, 2019 •
edited
Loading

Fixes #392

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2019
@JustinBeckwith JustinBeckwith changed the title Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion) [DO NOT MERGE] fix(deps): update to the latest version of teeny-request Jul 8, 2019
@JustinBeckwith JustinBeckwith added the status: blocked Resolving the issue is dependent on other work. label Jul 8, 2019
@callmehiphop
Copy link
Contributor

callmehiphop commented Aug 1, 2019

@JustinBeckwith haven't seen much going on here lately, but I'm wondering if we can close #459 in favor of this?

@JustinBeckwith JustinBeckwith changed the title [DO NOT MERGE] fix(deps): update to the latest version of teeny-request fix(deps): update to the latest version of teeny-request Aug 1, 2019
@JustinBeckwith JustinBeckwith removed the status: blocked Resolving the issue is dependent on other work. label Aug 1, 2019
@codecov
Copy link

codecov bot commented Aug 1, 2019 •
edited
Loading

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files           5        5           
  Lines         405      405           
  Branches       99       99           
=======================================
  Hits          398      398           
  Misses          2        2           
  Partials        5        5
Impacted Files Coverage Δ
src/service.ts 96.42% <ø> (ø) ⬆️
src/service-object.ts 99% <ø> (ø) ⬆️
src/util.ts 98.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608495e...cff58e7. Read the comment docs.

callmehiphop
callmehiphop reviewed Aug 1, 2019
View reviewed changes
package.json
"@types/nock": "^10.0.0",
"@types/node": "^11.13.0",
"@types/proxyquire": "^1.3.28",
"@types/request": "^2.48.1",
Copy link
Contributor

@callmehiphop callmehiphop Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this still?

Copy link
Contributor Author

@JustinBeckwith JustinBeckwith Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for now we do for tests.

@JustinBeckwith JustinBeckwith merged commit bb76f07 into master Aug 1, 2019
@jqll jqll mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@callmehiphop callmehiphop callmehiphop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@types included in dependencies

3 participants

@JustinBeckwith @callmehiphop @googlebot