fix: add close() in the wrapper#986
Merged
mutianf merged 7 commits intogoogleapis:mainfrom Jan 18, 2022
Merged
Conversation
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
Just one comment on a return value
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
Advice on making this a little more concise.
src/index.ts
Outdated
| * Terminate grpc channels and close all the clients. | ||
| */ | ||
| close(): Promise<void[]> { | ||
| const combined = []; |
Contributor
There was a problem hiding this comment.
I think to achieve what you want here we can condense the first ten lines of this function to const combined = Object.keys(this.api).map(clientType => this.api[clientType].close()).
Contributor
There was a problem hiding this comment.
If this isn't exactly right I can try to tweak it later or help with debugging.
Contributor
Author
There was a problem hiding this comment.
This works, thank you!
kolea2
reviewed
Jan 14, 2022
| /** | ||
| * Terminate grpc channels and close all the clients. | ||
| */ | ||
| close(): Promise<void[]> { |
Contributor
Author
There was a problem hiding this comment.
Maybe we can add a test to make sure request will fail after client is closed, I'll work on it next week!
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
Suggestions for end of close function
Closed
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
🤖 I have created a release *beep* *boop* --- ## [3.9.0](v3.8.0...v3.9.0) (2022-01-18) ### Features * add Autoscaling API ([#963](#963)) ([86d21e8](86d21e8)) ### Bug Fixes * add close() in the wrapper ([#986](#986)) ([839f429](839f429)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕