Skip to content

fix(browser): check for fetch on window#824

Merged
bcoe merged 6 commits intomasterfrom
autosynth-googleapis
Nov 23, 2020
Merged

fix(browser): check for fetch on window#824
bcoe merged 6 commits intomasterfrom
autosynth-googleapis

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Nov 19, 2020

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/e84ffa8a-673c-4e18-bb7b-113c6df811ad/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 343187793
Source-Link: googleapis/googleapis@5587028
PiperOrigin-RevId: 343136730
Source-Link: googleapis/googleapis@2cda8d2
PiperOrigin-RevId: 342976840
Source-Link: googleapis/googleapis@c979fbe
PiperOrigin-RevId: 342778480
Source-Link: googleapis/googleapis@c6b1c72
PiperOrigin-RevId: 341102751
Source-Link: googleapis/googleapis@b759c56

@yoshi-automation
changes without context
73fc1d6 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
fix: do not modify options object, use defaultScopes docs: regenerate…
4c0a770 
…d jsdoc comments with examples build: use gapic-generator-typescript v1.2.1

Note: these change require google-gax "^2.9.2". @alexander-fenster will make sure the google-gax version is bumped across libraries.
PiperOrigin-RevId: 341102751

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Nov 6 12:56:54 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: b759c563bacf9cd15749be4d2bdd276d3f48ee29
Source-Link: googleapis/googleapis@b759c56
@yoshi-automation
fix: better fallback feature detection, jsdoc update
c4017cd 
Use gapic-generator-typescript v1.2.2.

PiperOrigin-RevId: 342778480

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Nov 16 20:22:00 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: c6b1c72942991b1c605fe56a6041e06a86a9443e
Source-Link: googleapis/googleapis@c6b1c72
@yoshi-automation
fix: linting, updated jsdoc blocks
bebf382 
Use gapic-generator-typescript v1.2.3.

PiperOrigin-RevId: 342976840

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Nov 17 17:04:11 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: c979fbeb80d1b940790a69183629d799e4c05b4c
Source-Link: googleapis/googleapis@c979fbe
@yoshi-automation
fix: use optional chaining for window.fetch feature detection
c5683e2 
Use gapic-generator-typescript v1.2.4.
Committer: @alexander-fenster
PiperOrigin-RevId: 343136730

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Nov 18 12:49:25 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 2cda8d285b66c14da57363201b7e4efbca47d034
Source-Link: googleapis/googleapis@2cda8d2
@yoshi-automation
fix: mark window as global for linter
42d424b 
Use gapic-generator-typescript v1.2.5.
Committer: @alexander-fenster
PiperOrigin-RevId: 343187793

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Nov 18 17:10:02 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 5587028631d4d743fd906c4eb4e4e4649a7ee5ce
Source-Link: googleapis/googleapis@5587028
@yoshi-automation yoshi-automation requested a review from a team November 19, 2020 13:40
@yoshi-automation yoshi-automation requested a review from a team as a code owner November 19, 2020 13:40
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #824 (42d424b) into master (59a0d26) will decrease coverage by 0.01%.
The diff coverage is 98.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
- Coverage   99.24%   99.22%   -0.02%     
==========================================
  Files          18       18              
  Lines       17389    17413      +24     
  Branches     1022     1025       +3     
==========================================
+ Hits        17257    17278      +21     
- Misses        129      132       +3     
  Partials        3        3
Impacted Files Coverage Δ
src/v2/bigtable_client.ts 96.55% <96.66%> (-0.09%) ⬇️
src/v2/bigtable_instance_admin_client.ts 98.79% <99.08%> (-0.04%) ⬇️
src/v2/bigtable_table_admin_client.ts 98.96% <99.21%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a0d26...42d424b. Read the comment docs.

@bcoe bcoe changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. fix(browser): check for fetch on window Nov 23, 2020
@bcoe bcoe merged commit a38cbcc into master Nov 23, 2020
@bcoe bcoe deleted the autosynth-googleapis branch November 23, 2020 20:16
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 11, 2021
@release-please
chore: release 3.3.0 (#850)
c7d202b 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://www.github.com/googleapis/nodejs-bigtable/compare/v3.2.0...v3.3.0) (2021-03-08)


### Features

* add CMEK fields ([#845](https://www.github.com/googleapis/nodejs-bigtable/issues/845)) ([0381fb7](https://www.github.com/googleapis/nodejs-bigtable/commit/0381fb7da68492b85f8a3359d5fb97ca4898810e))
* introduce style enumeration ([#833](https://www.github.com/googleapis/nodejs-bigtable/issues/833)) ([99b7617](https://www.github.com/googleapis/nodejs-bigtable/commit/99b7617e215126fc36ef3c3ebefb244e0d8d2242))
* **protos:** update BigtableTableAdmin GetIamPolicy, change DeleteAppProfileRequest.ignore_warnings to REQUIRED ([59a0d26](https://www.github.com/googleapis/nodejs-bigtable/commit/59a0d269d5196991dd395e671d7d5f54ce449005))


### Bug Fixes

* **browser:** check for fetch on window ([#824](https://www.github.com/googleapis/nodejs-bigtable/issues/824)) ([a38cbcc](https://www.github.com/googleapis/nodejs-bigtable/commit/a38cbcca1660bc40fe137acb973bf62f3c55754e))
* Renaming region tags to not conflict with documentation snippets ([#834](https://www.github.com/googleapis/nodejs-bigtable/issues/834)) ([5d3e8f7](https://www.github.com/googleapis/nodejs-bigtable/commit/5d3e8f721c2a32a33bf41baa1ed237fb90f7cbd6))
* **retry:** restore grpc_service_config for CreateBackup and RestoreTable ([#851](https://www.github.com/googleapis/nodejs-bigtable/issues/851)) ([3ff2828](https://www.github.com/googleapis/nodejs-bigtable/commit/3ff282855f4f9a52a89bca8d087c1423e71bd7c6))
* set keepalive configuration ([#836](https://www.github.com/googleapis/nodejs-bigtable/issues/836)) ([8105dea](https://www.github.com/googleapis/nodejs-bigtable/commit/8105dea272de44e69915d3e62e5b5add106b54cb))


---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. cla: yes This human has signed the Contributor License Agreement. context: partial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoshi-automation @bcoe