fix: safe integer bounds conversion#576
Merged
jkwlui merged 4 commits intogoogleapis:masterfrom Nov 15, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 86.77% 86.82% +0.05%
==========================================
Files 33 33
Lines 1981 1981
Branches 349 349
==========================================
+ Hits 1719 1720 +1
Misses 233 233
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
Contributor
|
@laljikanjareeya could you please also add a unit test(s) where |
9ea1625 to
135c610
Compare
Contributor
Author
@AVaksman Added more unit tests for outside of bounds. |
Contributor
|
LGTM |
stephenplusplus
approved these changes
Nov 14, 2019
jkwlui
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking
MIN_SAFE_INTEGERandMAX_SAFE_INTEGERcondition, Added embedded functionNumber.isSafeIntegerto check safe integer.Fixes #575