-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.Issues related to the googleapis/nodejs-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":
- Search the issues already opened: https://github.com/googleapis/nodejs-bigtable/issues
- Search the issues on our "catch-all" repository: https://github.com/googleapis/google-cloud-node
- Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
If you are still having issues, please be sure to include as much information as possible:
Environment details
- OS: MacOS 10.4, Windows 10
- Node.js version: !2.3.1
- npm version: 6.10.2
@google-cloud/bigtableversion: 1.0.1
Steps to reproduce
- Set an Integer column to Number.MIN_SAFE_INTEGER or Number.MAX_SAFE_INTEGER, via some other method
- Attempt to read the value. Using this library
- See that the value returned is a string.
Source:
nodejs-bigtable/src/mutation.ts
Line 114 in 1cb65a4
| if (Number.MIN_SAFE_INTEGER < num && num < Number.MAX_SAFE_INTEGER) { |
This line should read
if (Number.MIN_SAFE_INTEGER <= num && num <= Number.MAX_SAFE_INTEGER) {
to include the SAFE_INTEGER bounds.
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.Issues related to the googleapis/nodejs-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.