Fixing the Hello world#339
Merged
JustinBeckwith merged 3 commits intogoogleapis:masterfrom Oct 26, 2018
Merged
Conversation
The json for family name was incorrect
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 1287 1287
=====================================
Hits 1287 1287Continue to review full report at Codecov.
|
Contributor
Author
|
@googleapis/yoshi-nodejs, I can use some help here. It looks like node11 tests can't install grpc, so the tests fail. Everything else seems to pass. |
stephenplusplus
approved these changes
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The json for family name in the system test was incorrect. It was "id", but should have been "name"