fix: fix createReadStream retry from sending a full table scan#1026
Merged
mutianf merged 5 commits intogoogleapis:mainfrom Mar 16, 2022
Merged
fix: fix createReadStream retry from sending a full table scan#1026mutianf merged 5 commits intogoogleapis:mainfrom
mutianf merged 5 commits intogoogleapis:mainfrom
Conversation
igorbernstein2
requested changes
Mar 15, 2022
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
Just a comment about the conditions that result in a full table scan.
mutianf
commented
Mar 15, 2022
igorbernstein2
approved these changes
Mar 15, 2022
Contributor
igorbernstein2
left a comment
There was a problem hiding this comment.
lgtm. after the buffer end check
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
🤖 I have created a release *beep* *boop* --- ### [3.9.3](v3.9.2...v3.9.3) (2022-03-16) ### Bug Fixes * fix createReadStream retry from sending a full table scan ([#1026](#1026)) ([f926992](f926992)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕