-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.Issues related to the googleapis/nodejs-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
Description
The code for table.ts is a bit complicated and can likely be streamlined. In order to retry, we nest two streams.
It is likely worth removing the two instances of through and subclassing stream. This should help to shutdown on termination and not attempt writes past that point.
This also will remove dependencies on through2 and readable-stream
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.Issues related to the googleapis/nodejs-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.