Skip to content

ci: Add description to release binary table#599

Merged
duwenxin99 merged 2 commits into
mainfrom
bi-name
May 21, 2025
Merged

ci: Add description to release binary table#599
duwenxin99 merged 2 commits into
mainfrom
bi-name

Conversation

@duwenxin99

@duwenxin99 duwenxin99 commented May 21, 2025

Copy link
Copy Markdown
Contributor

We have received multiple user inquiries about which binary to use for macOS. We should clear out the confusions by providing a description to each binary, making it clearer which machine type it is for.

Fix issue: #590

Example release binary table after this change:
Screenshot 2025-05-21 at 1 58 26 PM

@duwenxin99 duwenxin99 requested a review from a team May 21, 2025 17:54
@duwenxin99 duwenxin99 merged commit d6dc0c5 into main May 21, 2025
6 checks passed
@duwenxin99 duwenxin99 deleted the bi-name branch May 21, 2025 18:05
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
Changes from `next` to be merged into `main`
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
## Problem

In client-server messaging, the A2A protocol uses the [JSON-RPC
2.0](https://www.jsonrpc.org/specification) format, and the protocol
specification is written using the [JSON-Schema
specification](https://json-schema.org/). Fully complying with the
standards can help validate the payloads more accurately and help better
test different client and server implementations.

In addition to making the A2A spec more compliant with the mentioned
standards, changes in this PR are meant to fix a few minor bugs in the
A2A protocol spec (mismatches from what was implemented in the sample
A2A server and clients.

Addresses issue googleapis#353.

## Summary of changes
* Makes field "id" required on requests and responses. This field is
important because, according to the JSON RPC 2.0 spec, a message that
does not have an "id" is considered a notification, and the callee does
not have to send a response to such requests. Similarly, without the
"id" on the responses, the caller cannot correlate the responses to the
pending requests, meaning that fully JSON-RPC-compliant clients would
not be able to resolve such RPC calls.

---
*Edit: clearer wording + add issue references*

*Edit2: the scope of this PR has been reduced due to other updates
fixing parts of the spec, summary items were edited to reflect what has
already been addressed in other PRs.*

---

## (OLD) Summary of changes

* Add a missing definition for "TaskSendParams.acceptedOutputModes"
(described in googleapis#354). Fixed in googleapis#599.

* Remove "default" values for "const" fields. Compliance with JSON
schema, version `>=draft-6` and reduce ambiguity.
https://json-schema.org/understanding-json-schema/reference/const
Fixed in googleapis#599

* Make fields "jsonrpc" and "id" required on requests and responses.
Compliance with JSON-RPC 2.0.

* Make fields "error.code" and "error.message" required on errors. Fixed
in googleapis#599.

* In a few places, sort non-top-level dict keys to make them more
aligned with the pydantic JSON schema outputs. Since now, we are
discouraged from editing the spec manually, this item also drops out of
the scope of our concerns.

* The initial commit in this PR also included cleaning up several
unnecessary "null" types, which were addressed more thoroughly in googleapis#352.

## (OLD) Additional notes

While I sorted dictionaries within each model so that the keys of each
model would be in the same order as the pydantic-based scripts' exports,
at the same time, **I decided not to sort the top-level keys**
(`$defs/ModelKey`). Because doing so would make the diff ugly and harder
to read the applied changes. The top-level key sorting can be done
afterward.

---------

Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Co-authored-by: kthota-g <kcthota@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants