chore: move sources into their own packages#41
Closed
kurtisvg wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superceded by #42 |
6 tasks
averikitsch
added a commit
that referenced
this pull request
Nov 12, 2025
#1927) ### Description This pull request addresses issue #41 by implementing default connection values for the Postgresql data source. When a user does not specify a host or port, the connection will now automatically default to `localhost:5432`. --- ### Detailed Changes - **docs/en/reference/prebuilt-tools.md** -updated the env variables host and port to optional in the doc - **internal/prebuiltconfigs/tools/postgres.yaml** - Added the default values to host and port. Specifically, they are now `host: ${POSTGRES_HOST:localhost}` and `port: ${POSTGRES_PORT:5432}`. This allows the configuration loader to directly use `"localhost"` or `"5432"` as a fallback if the `POSTGRES_HOST` or `POSTGRES_PORT` environment variables are not set. --- ### PR Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed CONTRIBUTING.md - [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change 🛠️ **Fixes** #41 --------- Co-authored-by: Averi Kitsch <akitsch@google.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
…ql source (#1927) ### Description This pull request addresses issue #41 by implementing default connection values for the Postgresql data source. When a user does not specify a host or port, the connection will now automatically default to `localhost:5432`. --- ### Detailed Changes - **docs/en/reference/prebuilt-tools.md** -updated the env variables host and port to optional in the doc - **internal/prebuiltconfigs/tools/postgres.yaml** - Added the default values to host and port. Specifically, they are now `host: ${POSTGRES_HOST:localhost}` and `port: ${POSTGRES_PORT:5432}`. This allows the configuration loader to directly use `"localhost"` or `"5432"` as a fallback if the `POSTGRES_HOST` or `POSTGRES_PORT` environment variables are not set. --- ### PR Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed CONTRIBUTING.md - [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change 🛠️ **Fixes** #41 --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 7e6e88a
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
…ql source (#1927) ### Description This pull request addresses issue #41 by implementing default connection values for the Postgresql data source. When a user does not specify a host or port, the connection will now automatically default to `localhost:5432`. --- ### Detailed Changes - **docs/en/reference/prebuilt-tools.md** -updated the env variables host and port to optional in the doc - **internal/prebuiltconfigs/tools/postgres.yaml** - Added the default values to host and port. Specifically, they are now `host: ${POSTGRES_HOST:localhost}` and `port: ${POSTGRES_PORT:5432}`. This allows the configuration loader to directly use `"localhost"` or `"5432"` as a fallback if the `POSTGRES_HOST` or `POSTGRES_PORT` environment variables are not set. --- ### PR Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed CONTRIBUTING.md - [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change 🛠️ **Fixes** #41 --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 7e6e88a
github-actions Bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Nov 12, 2025
…ql source (googleapis#1927) ### Description This pull request addresses issue googleapis#41 by implementing default connection values for the Postgresql data source. When a user does not specify a host or port, the connection will now automatically default to `localhost:5432`. --- ### Detailed Changes - **docs/en/reference/prebuilt-tools.md** -updated the env variables host and port to optional in the doc - **internal/prebuiltconfigs/tools/postgres.yaml** - Added the default values to host and port. Specifically, they are now `host: ${POSTGRES_HOST:localhost}` and `port: ${POSTGRES_PORT:5432}`. This allows the configuration loader to directly use `"localhost"` or `"5432"` as a fallback if the `POSTGRES_HOST` or `POSTGRES_PORT` environment variables are not set. --- ### PR Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed CONTRIBUTING.md - [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change 🛠️ **Fixes** googleapis#41 --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 7e6e88a
github-actions Bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Nov 12, 2025
…ql source (googleapis#1927) ### Description This pull request addresses issue googleapis#41 by implementing default connection values for the Postgresql data source. When a user does not specify a host or port, the connection will now automatically default to `localhost:5432`. --- ### Detailed Changes - **docs/en/reference/prebuilt-tools.md** -updated the env variables host and port to optional in the doc - **internal/prebuiltconfigs/tools/postgres.yaml** - Added the default values to host and port. Specifically, they are now `host: ${POSTGRES_HOST:localhost}` and `port: ${POSTGRES_PORT:5432}`. This allows the configuration loader to directly use `"localhost"` or `"5432"` as a fallback if the `POSTGRES_HOST` or `POSTGRES_PORT` environment variables are not set. --- ### PR Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed CONTRIBUTING.md - [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change 🛠️ **Fixes** googleapis#41 --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 7e6e88a
rahulpinto19
pushed a commit
that referenced
this pull request
Nov 18, 2025
#1927) ### Description This pull request addresses issue #41 by implementing default connection values for the Postgresql data source. When a user does not specify a host or port, the connection will now automatically default to `localhost:5432`. --- ### Detailed Changes - **docs/en/reference/prebuilt-tools.md** -updated the env variables host and port to optional in the doc - **internal/prebuiltconfigs/tools/postgres.yaml** - Added the default values to host and port. Specifically, they are now `host: ${POSTGRES_HOST:localhost}` and `port: ${POSTGRES_PORT:5432}`. This allows the configuration loader to directly use `"localhost"` or `"5432"` as a fallback if the `POSTGRES_HOST` or `POSTGRES_PORT` environment variables are not set. --- ### PR Checklist Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed CONTRIBUTING.md - [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add ! if this involve a breaking change 🛠️ **Fixes** #41 --------- Co-authored-by: Averi Kitsch <akitsch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.