fix(tool)!: initialize query result slices to empty array by duwenxin99 · Pull Request #3250 · googleapis/mcp-toolbox

duwenxin99 · 2026-05-18T21:09:49Z

Initialize empty slice for result response in tool call methods.
Update expected integration test result from "null" to empty slice.

…tead of nil

…array

gemini-code-assist

Code Review

This pull request updates various database source and tool implementations to initialize the result slice out as an empty slice ([]any{}) instead of a nil slice. This ensures that functions return an empty collection rather than nil when no data is retrieved. Feedback was provided to update existing code comments in cloud_sql_mssql.go and mssql.go that have become outdated as they still describe the variable as being nil under certain conditions.

…tabase integration tests

…o empty slice

…ices in integration test helpers

… expect empty slices in postgres

…mpty slice

…in mysql tests

github-actions · 2026-05-21T16:22:00Z

🧨 Preview deployments removed.

Cloudflare Pages environments for pr-3250 have been deleted.

🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2026-05-21) ### Features * **auth:** Implement MCP auth tool-level scopes validation ([#3049](#3049)) ([c528985](c528985)) * **looker:** Propagate client IP from incoming MCP requests to downstream SDK calls ([#3253](#3253)) ([75da6c2](75da6c2)) * Setup SQLCommenter and allow client metadata ([#3064](#3064)) ([9f1f9b3](9f1f9b3)) * **tool/cloudsqladmin:** Add `cloud-sql-admin-execute-sql-many` and `cloud-sql-admin-sql-many` ([#3083](#3083)) ([ef300a8](ef300a8)) ### Bug Fixes * **auth/generic:** Fix generic auth expiration field and integration with `authRequired` ([#3251](#3251)) ([f4d16c0](f4d16c0)) * Enforce toolset/promptset boundary on tools/call and prompts/get ([#3036](#3036)) ([c739b80](c739b80)) * **tools/http:** Prevent path traversal and base path scope escape ([#3218](#3218)) ([80a6602](80a6602)) * **tools/looker:** Return a 401 error to MCP client when Looker returns a 401 ([#3233](#3233)) ([4f409a3](4f409a3)) * **tools/looker:** Strip wrapping quotes from filter values for unquoted parameters ([#3273](#3273)) ([1e3de96](1e3de96)) * **tools:** Initialize query result slices to empty array ([#3250](#3250)) ([60ddf48](60ddf48)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2026-05-21) ### Features * **auth:** Implement MCP auth tool-level scopes validation ([#3049](#3049)) ([c528985](c528985)) * **looker:** Propagate client IP from incoming MCP requests to downstream SDK calls ([#3253](#3253)) ([75da6c2](75da6c2)) * Setup SQLCommenter and allow client metadata ([#3064](#3064)) ([9f1f9b3](9f1f9b3)) * **tool/cloudsqladmin:** Add `cloud-sql-admin-execute-sql-many` and `cloud-sql-admin-sql-many` ([#3083](#3083)) ([ef300a8](ef300a8)) ### Bug Fixes * **auth/generic:** Fix generic auth expiration field and integration with `authRequired` ([#3251](#3251)) ([f4d16c0](f4d16c0)) * Enforce toolset/promptset boundary on tools/call and prompts/get ([#3036](#3036)) ([c739b80](c739b80)) * **tools/http:** Prevent path traversal and base path scope escape ([#3218](#3218)) ([80a6602](80a6602)) * **tools/looker:** Return a 401 error to MCP client when Looker returns a 401 ([#3233](#3233)) ([4f409a3](4f409a3)) * **tools/looker:** Strip wrapping quotes from filter values for unquoted parameters ([#3273](#3273)) ([1e3de96](1e3de96)) * **tools:** Initialize query result slices to empty array ([#3250](#3250)) ([60ddf48](60ddf48)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> b001006

🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/mcp-toolbox@v1.2.0...v1.3.0) (2026-05-21) ### Features * **auth:** Implement MCP auth tool-level scopes validation ([googleapis#3049](googleapis#3049)) ([c528985](googleapis@c528985)) * **looker:** Propagate client IP from incoming MCP requests to downstream SDK calls ([googleapis#3253](googleapis#3253)) ([75da6c2](googleapis@75da6c2)) * Setup SQLCommenter and allow client metadata ([googleapis#3064](googleapis#3064)) ([9f1f9b3](googleapis@9f1f9b3)) * **tool/cloudsqladmin:** Add `cloud-sql-admin-execute-sql-many` and `cloud-sql-admin-sql-many` ([googleapis#3083](googleapis#3083)) ([ef300a8](googleapis@ef300a8)) ### Bug Fixes * **auth/generic:** Fix generic auth expiration field and integration with `authRequired` ([googleapis#3251](googleapis#3251)) ([f4d16c0](googleapis@f4d16c0)) * Enforce toolset/promptset boundary on tools/call and prompts/get ([googleapis#3036](googleapis#3036)) ([c739b80](googleapis@c739b80)) * **tools/http:** Prevent path traversal and base path scope escape ([googleapis#3218](googleapis#3218)) ([80a6602](googleapis@80a6602)) * **tools/looker:** Return a 401 error to MCP client when Looker returns a 401 ([googleapis#3233](googleapis#3233)) ([4f409a3](googleapis@4f409a3)) * **tools/looker:** Strip wrapping quotes from filter values for unquoted parameters ([googleapis#3273](googleapis#3273)) ([1e3de96](googleapis@1e3de96)) * **tools:** Initialize query result slices to empty array ([googleapis#3250](googleapis#3250)) ([60ddf48](googleapis@60ddf48)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> b001006

fix(sources,tools): initialize query result slices to empty array ins…

3aaf056

…tead of nil

duwenxin99 requested review from a team as code owners May 18, 2026 21:09

duwenxin99 changed the title ~~fix(sources,tools): initialize query result slices to empty array ins…~~ fix(sources,tools): initialize query result slices to empty array May 18, 2026

blunderbuss-gcf Bot assigned Yuan325 May 18, 2026

duwenxin99 changed the title ~~fix(sources,tools): initialize query result slices to empty array~~ fix(tools): initialize query result slices to empty array May 18, 2026

test(integration): update tool invoke expected empty result to empty …

eba51aa

…array

gemini-code-assist Bot reviewed May 18, 2026

View reviewed changes

Comment thread internal/sources/cloudsqlmssql/cloud_sql_mssql.go

Comment thread internal/sources/mssql/mssql.go

duwenxin99 added 2 commits May 18, 2026 17:20

test(integration): rename nil response test to empty slice response

b24a0b8

update comment

1922c52

averikitsch approved these changes May 18, 2026

View reviewed changes

duwenxin99 added the release candidate Use label to signal PR should be included in the next release. label May 20, 2026

duwenxin99 and others added 3 commits May 20, 2026 17:09

fix test

5e23c94

Merge branch 'main' into fix/nil-slice

82413f5

test(integration): update expected null outputs to empty slices in da…

a807cd1

…tabase integration tests

duwenxin99 enabled auto-merge (squash) May 20, 2026 21:27

duwenxin99 changed the title ~~fix(tools): initialize query result slices to empty array~~ fix(tools)!: initialize query result slices to empty array May 20, 2026

duwenxin99 changed the title ~~fix(tools)!: initialize query result slices to empty array~~ fix(tool)!: initialize query result slices to empty array May 20, 2026

duwenxin99 and others added 6 commits May 20, 2026 17:32

test(source/singlestore): update semantic search insert expectation t…

c49add8

…o empty slice

test(integration): update expected metadata query results to empty sl…

92a45bc

…ices in integration test helpers

test(integration): update remaining empty metadata list assertions to…

d717bf6

… expect empty slices in postgres

test(integration): update expected list_pg_settings empty result to e…

7194a41

…mpty slice

test(integration): initialize empty slices for MCP JSON null results …

b654a17

…in mysql tests

Merge branch 'main' into fix/nil-slice

55e56ef

duwenxin99 merged commit 60ddf48 into main May 21, 2026
23 checks passed

duwenxin99 deleted the fix/nil-slice branch May 21, 2026 16:21

release-please Bot mentioned this pull request May 21, 2026

chore(main): release 1.3.0 #3228

Merged

BrewTestBot mentioned this pull request May 21, 2026

mcp-toolbox 1.3.0 Homebrew/homebrew-core#284130

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tool)!: initialize query result slices to empty array#3250

fix(tool)!: initialize query result slices to empty array#3250
duwenxin99 merged 13 commits into
mainfrom
fix/nil-slice

duwenxin99 commented May 18, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

duwenxin99 commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

duwenxin99 commented May 18, 2026 •

edited

Loading