refactor: Add GetParameters() to Tools interface#2374
Conversation
ParaseParams() from ToolsGetParameters() to Tools interface
Summary of ChangesHello @duwenxin99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactoring to standardize parameter management across the toolset. By adding a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Tool interface by adding a new GetParameters() method, and implements this method across various tool files. This change standardizes how tool parameters are accessed, which is a good step towards improving the overall architecture and maintainability. I've identified a couple of critical issues related to typos that need to be addressed.
44d7555 to
b85fe93
Compare
The `ParseParams` Tool interface is only passing the tool's parameter into a generic `parameters.ParseParams()` helper. Instead of keeping it as a tool interface, we add a `GetParameters()` method (#2374) to the tool interface and call it directly from the API handlers. This way we keep the parameter parsing logic independent from the tools.
…pis#2375) The `ParseParams` Tool interface is only passing the tool's parameter into a generic `parameters.ParseParams()` helper. Instead of keeping it as a tool interface, we add a `GetParameters()` method (googleapis#2374) to the tool interface and call it directly from the API handlers. This way we keep the parameter parsing logic independent from the tools. 2d5d333
As a first part to refactor the `ParseParam()` method of the Tool interface.
The `ParseParams` Tool interface is only passing the tool's parameter into a generic `parameters.ParseParams()` helper. Instead of keeping it as a tool interface, we add a `GetParameters()` method (googleapis#2374) to the tool interface and call it directly from the API handlers. This way we keep the parameter parsing logic independent from the tools.
As a first part to refactor the `ParseParam()` method of the Tool interface.
The `ParseParams` Tool interface is only passing the tool's parameter into a generic `parameters.ParseParams()` helper. Instead of keeping it as a tool interface, we add a `GetParameters()` method (googleapis#2374) to the tool interface and call it directly from the API handlers. This way we keep the parameter parsing logic independent from the tools.
The `ParseParams` Tool interface is only passing the tool's parameter into a generic `parameters.ParseParams()` helper. Instead of keeping it as a tool interface, we add a `GetParameters()` method (googleapis/mcp-toolbox#2374) to the tool interface and call it directly from the API handlers. This way we keep the parameter parsing logic independent from the tools.
As a first part to refactor the
ParseParam()method of the Tool interface.