Skip to content

docs: update cloud run connection docs#2320

Merged
twishabansal merged 2 commits into
mainfrom
twishabansal-patch-2
Jan 16, 2026
Merged

docs: update cloud run connection docs#2320
twishabansal merged 2 commits into
mainfrom
twishabansal-patch-2

Conversation

@twishabansal

@twishabansal twishabansal commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Partially fixes googleapis/mcp-toolbox-sdk-python#496

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@gemini-code-assist

gemini-code-assist Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @twishabansal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for connecting to Toolbox Cloud Run instances. It modifies the Python code example to include the protocol argument when initializing the ToolboxClient, ensuring users correctly configure their connections. This change reflects an underlying update in the toolbox_core library's client initialization requirements.

Highlights

  • Documentation Update: The deploy_toolbox.md documentation has been updated to reflect changes in how to connect to Toolbox Cloud Run instances.
  • ToolboxClient Initialization: The Python example for ToolboxClient initialization now explicitly includes the protocol=Protocol.TOOLBOX argument.
  • New Import Statement: An import statement for Protocol from toolbox_core.protocol has been added to support the updated ToolboxClient usage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Python SDK example in the Cloud Run deployment documentation. The addition of the protocol parameter seems correct and necessary. I've added one suggestion to include a comment explaining this new parameter to improve clarity for users.

While the change itself is good, I noticed some inconsistencies in the surrounding documentation that you might want to address in a follow-up to improve the user experience:

  • The Javascript and Go examples use a misleading localhost URL instead of a Cloud Run URL placeholder.
  • It would be beneficial to check if the Javascript and Go SDKs also require a similar protocol update for consistency.
  • The numbered list in the 'Connecting with Toolbox Client SDK' section is incorrect.

Addressing these would make the documentation more consistent and easier to follow.

Comment thread docs/en/how-to/deploy_toolbox.md
@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2320/

@twishabansal twishabansal marked this pull request as ready for review January 16, 2026 03:49
@twishabansal twishabansal requested a review from a team January 16, 2026 03:49
@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2320/

@twishabansal twishabansal mentioned this pull request Jan 16, 2026
Closed
3 tasks
anubhav756
anubhav756 approved these changes Jan 16, 2026
View reviewed changes
Comment thread docs/en/how-to/deploy_toolbox.md
@twishabansal twishabansal merged commit dfddeb5 into main Jan 16, 2026
13 checks passed
@twishabansal twishabansal deleted the twishabansal-patch-2 branch January 16, 2026 04:35
@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

github-actions Bot pushed a commit that referenced this pull request Jan 16, 2026
@twishabansal
deploy: docs: update cloud run connection docs (#2320)
7ad00a7 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here> dfddeb5
github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Jan 16, 2026
@renovate-bot
deploy: docs: update cloud run connection docs (googleapis#2320)
1052f53 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here> dfddeb5
github-actions Bot pushed a commit to NirajNandre/genai-toolbox-fork that referenced this pull request Jan 16, 2026
@NirajNandre
deploy: docs: update cloud run connection docs (googleapis#2320)
e0842c9 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here> dfddeb5
github-actions Bot pushed a commit to Jaleel-zhu/genai-toolbox that referenced this pull request Jan 16, 2026
@pull
deploy: docs: update cloud run connection docs (googleapis#2320)
87b82af 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here> dfddeb5
github-actions Bot pushed a commit to ishatilwani1301/genai-toolbox that referenced this pull request Jan 16, 2026
@ishatilwani1301
deploy: docs: update cloud run connection docs (googleapis#2320)
731987f 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here> dfddeb5
github-actions Bot pushed a commit to CrazyForks/genai-toolbox that referenced this pull request Jan 16, 2026
@pull
deploy: docs: update cloud run connection docs (googleapis#2320)
19a6770 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here> dfddeb5
mahlevanshika pushed a commit to mahlevanshika/genai-toolbox that referenced this pull request Jan 22, 2026
@twishabansal @mahlevanshika
docs: update cloud run connection docs (googleapis#2320)
ca6d67d 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
kshalu-code pushed a commit to kshalu-code/genai-toolbox that referenced this pull request Feb 4, 2026
@twishabansal @kshalu-code
docs: update cloud run connection docs (googleapis#2320)
57c41cc 
## Description

Partially fixes
googleapis/mcp-toolbox-sdk-python#496

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anubhav756 anubhav756 anubhav756 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Yuan325 Yuan325

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Invalid JWT audience. When connecting to Cloud Run using IAP

3 participants

@twishabansal @anubhav756 @Yuan325