fix(embeddingModel): add embedding model to MCP handler by duwenxin99 · Pull Request #2310 · googleapis/mcp-toolbox

duwenxin99 · 2026-01-14T21:05:19Z

Add embedding model to mcp handlers
Add integration tests

gemini-code-assist · 2026-01-14T21:05:31Z

Summary of Changes

Hello @duwenxin99, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial enhancement to the Multi-Cloud Platform (MCP) handler by integrating embedding model processing directly into the tool invocation workflow. This ensures that all input parameters are appropriately transformed using embedding models, which is vital for advanced data processing and interpretation within the system.

Highlights

Embedding Model Integration: The toolsCallHandler now retrieves available embedding models and utilizes them to process invocation parameters via tool.EmbedParams before proceeding with the actual tool invocation. This ensures that parameters are properly embedded, enhancing data interpretation.
Error Handling for Embedding: Robust error handling has been added for the parameter embedding process. If tool.EmbedParams encounters an error, it now returns a jsonrpc.INVALID_PARAMS error, preventing further execution with malformed or un-embeddable parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for parameter embedding in the toolsCallHandler for the v20241105 MCP API version. The change correctly retrieves embedding models and calls the tool.EmbedParams method.

My main feedback is to consider the scope of this change. This fix/feature has been applied to the v20241105 API version, but not to the newer versions present in the codebase (v20250326, v20250618). Please verify if this change should also be propagated to those versions to ensure consistent behavior across all supported API versions.

Additionally, I've left a comment regarding error handling to make it more robust.

Added API_KEY to secret environment variables for integration.

…leapis#2310) - Add embedding model to mcp handlers - Add integration tests e4f60e5

) - Add embedding model to mcp handlers - Add integration tests

🤖 I have created a release *beep* *boop* --- ## [0.26.0](v0.25.0...v0.26.0) (2026-01-22) ### ⚠ BREAKING CHANGES * Validate tool naming ([#2305](#2305)) ([5054212](5054212)) * **tools/cloudgda:** Update description and parameter name for cloudgda tool ([#2288](#2288)) ([6b02591](6b02591)) ### Features * Add new `user-agent-metadata` flag ([#2302](#2302)) ([adc9589](adc9589)) * Add remaining flag to Toolbox server in MCP registry ([#2272](#2272)) ([5e0999e](5e0999e)) * **embeddingModel:** Add embedding model to MCP handler ([#2310](#2310)) ([e4f60e5](e4f60e5)) * **sources/bigquery:** Make maximum rows returned from queries configurable ([#2262](#2262)) ([4abf0c3](4abf0c3)) * **prebuilt/cloud-sql:** Add create backup tool for Cloud SQL ([#2141](#2141)) ([8e0fb03](8e0fb03)) * **prebuilt/cloud-sql:** Add restore backup tool for Cloud SQL ([#2171](#2171)) ([00c3e6d](00c3e6d)) * Support combining multiple prebuilt configurations ([#2295](#2295)) ([e535b37](e535b37)) * Support MCP specs version 2025-11-25 ([#2303](#2303)) ([4d23a3b](4d23a3b)) * **tools:** Add `valueFromParam` support to Tool config ([#2333](#2333)) ([15101b1](15101b1)) ### Bug Fixes * **tools/cloudhealthcare:** Add check for client authorization before retrieving token string ([#2327](#2327)) ([c25a233](c25a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.26.0](v0.25.0...v0.26.0) (2026-01-22) ### ⚠ BREAKING CHANGES * Validate tool naming ([#2305](#2305)) ([5054212](5054212)) * **tools/cloudgda:** Update description and parameter name for cloudgda tool ([#2288](#2288)) ([6b02591](6b02591)) ### Features * Add new `user-agent-metadata` flag ([#2302](#2302)) ([adc9589](adc9589)) * Add remaining flag to Toolbox server in MCP registry ([#2272](#2272)) ([5e0999e](5e0999e)) * **embeddingModel:** Add embedding model to MCP handler ([#2310](#2310)) ([e4f60e5](e4f60e5)) * **sources/bigquery:** Make maximum rows returned from queries configurable ([#2262](#2262)) ([4abf0c3](4abf0c3)) * **prebuilt/cloud-sql:** Add create backup tool for Cloud SQL ([#2141](#2141)) ([8e0fb03](8e0fb03)) * **prebuilt/cloud-sql:** Add restore backup tool for Cloud SQL ([#2171](#2171)) ([00c3e6d](00c3e6d)) * Support combining multiple prebuilt configurations ([#2295](#2295)) ([e535b37](e535b37)) * Support MCP specs version 2025-11-25 ([#2303](#2303)) ([4d23a3b](4d23a3b)) * **tools:** Add `valueFromParam` support to Tool config ([#2333](#2333)) ([15101b1](15101b1)) ### Bug Fixes * **tools/cloudhealthcare:** Add check for client authorization before retrieving token string ([#2327](#2327)) ([c25a233](c25a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 86bf7bf

🤖 I have created a release *beep* *boop* --- ## [0.26.0](googleapis/mcp-toolbox@v0.25.0...v0.26.0) (2026-01-22) ### ⚠ BREAKING CHANGES * Validate tool naming ([googleapis#2305](googleapis#2305)) ([5054212](googleapis@5054212)) * **tools/cloudgda:** Update description and parameter name for cloudgda tool ([googleapis#2288](googleapis#2288)) ([6b02591](googleapis@6b02591)) ### Features * Add new `user-agent-metadata` flag ([googleapis#2302](googleapis#2302)) ([adc9589](googleapis@adc9589)) * Add remaining flag to Toolbox server in MCP registry ([googleapis#2272](googleapis#2272)) ([5e0999e](googleapis@5e0999e)) * **embeddingModel:** Add embedding model to MCP handler ([googleapis#2310](googleapis#2310)) ([e4f60e5](googleapis@e4f60e5)) * **sources/bigquery:** Make maximum rows returned from queries configurable ([googleapis#2262](googleapis#2262)) ([4abf0c3](googleapis@4abf0c3)) * **prebuilt/cloud-sql:** Add create backup tool for Cloud SQL ([googleapis#2141](googleapis#2141)) ([8e0fb03](googleapis@8e0fb03)) * **prebuilt/cloud-sql:** Add restore backup tool for Cloud SQL ([googleapis#2171](googleapis#2171)) ([00c3e6d](googleapis@00c3e6d)) * Support combining multiple prebuilt configurations ([googleapis#2295](googleapis#2295)) ([e535b37](googleapis@e535b37)) * Support MCP specs version 2025-11-25 ([googleapis#2303](googleapis#2303)) ([4d23a3b](googleapis@4d23a3b)) * **tools:** Add `valueFromParam` support to Tool config ([googleapis#2333](googleapis#2333)) ([15101b1](googleapis@15101b1)) ### Bug Fixes * **tools/cloudhealthcare:** Add check for client authorization before retrieving token string ([googleapis#2327](googleapis#2327)) ([c25a233](googleapis@c25a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 86bf7bf

🤖 I have created a release *beep* *boop* --- ## [0.26.0](googleapis/mcp-toolbox@v0.25.0...v0.26.0) (2026-01-22) ### ⚠ BREAKING CHANGES * Validate tool naming ([googleapis#2305](googleapis#2305)) ([5054212](googleapis@5054212)) * **tools/cloudgda:** Update description and parameter name for cloudgda tool ([googleapis#2288](googleapis#2288)) ([6b02591](googleapis@6b02591)) ### Features * Add new `user-agent-metadata` flag ([googleapis#2302](googleapis#2302)) ([adc9589](googleapis@adc9589)) * Add remaining flag to Toolbox server in MCP registry ([googleapis#2272](googleapis#2272)) ([5e0999e](googleapis@5e0999e)) * **embeddingModel:** Add embedding model to MCP handler ([googleapis#2310](googleapis#2310)) ([e4f60e5](googleapis@e4f60e5)) * **sources/bigquery:** Make maximum rows returned from queries configurable ([googleapis#2262](googleapis#2262)) ([4abf0c3](googleapis@4abf0c3)) * **prebuilt/cloud-sql:** Add create backup tool for Cloud SQL ([googleapis#2141](googleapis#2141)) ([8e0fb03](googleapis@8e0fb03)) * **prebuilt/cloud-sql:** Add restore backup tool for Cloud SQL ([googleapis#2171](googleapis#2171)) ([00c3e6d](googleapis@00c3e6d)) * Support combining multiple prebuilt configurations ([googleapis#2295](googleapis#2295)) ([e535b37](googleapis@e535b37)) * Support MCP specs version 2025-11-25 ([googleapis#2303](googleapis#2303)) ([4d23a3b](googleapis@4d23a3b)) * **tools:** Add `valueFromParam` support to Tool config ([googleapis#2333](googleapis#2333)) ([15101b1](googleapis@15101b1)) ### Bug Fixes * **tools/cloudhealthcare:** Add check for client authorization before retrieving token string ([googleapis#2327](googleapis#2327)) ([c25a233](googleapis@c25a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

) - Add embedding model to mcp handlers - Add integration tests

🤖 I have created a release *beep* *boop* --- ## [0.26.0](googleapis/mcp-toolbox@v0.25.0...v0.26.0) (2026-01-22) ### ⚠ BREAKING CHANGES * Validate tool naming ([googleapis#2305](googleapis#2305)) ([5054212](googleapis@5054212)) * **tools/cloudgda:** Update description and parameter name for cloudgda tool ([googleapis#2288](googleapis#2288)) ([6b02591](googleapis@6b02591)) ### Features * Add new `user-agent-metadata` flag ([googleapis#2302](googleapis#2302)) ([adc9589](googleapis@adc9589)) * Add remaining flag to Toolbox server in MCP registry ([googleapis#2272](googleapis#2272)) ([5e0999e](googleapis@5e0999e)) * **embeddingModel:** Add embedding model to MCP handler ([googleapis#2310](googleapis#2310)) ([e4f60e5](googleapis@e4f60e5)) * **sources/bigquery:** Make maximum rows returned from queries configurable ([googleapis#2262](googleapis#2262)) ([4abf0c3](googleapis@4abf0c3)) * **prebuilt/cloud-sql:** Add create backup tool for Cloud SQL ([googleapis#2141](googleapis#2141)) ([8e0fb03](googleapis@8e0fb03)) * **prebuilt/cloud-sql:** Add restore backup tool for Cloud SQL ([googleapis#2171](googleapis#2171)) ([00c3e6d](googleapis@00c3e6d)) * Support combining multiple prebuilt configurations ([googleapis#2295](googleapis#2295)) ([e535b37](googleapis@e535b37)) * Support MCP specs version 2025-11-25 ([googleapis#2303](googleapis#2303)) ([4d23a3b](googleapis@4d23a3b)) * **tools:** Add `valueFromParam` support to Tool config ([googleapis#2333](googleapis#2333)) ([15101b1](googleapis@15101b1)) ### Bug Fixes * **tools/cloudhealthcare:** Add check for client authorization before retrieving token string ([googleapis#2327](googleapis#2327)) ([c25a233](googleapis@c25a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.26.0](googleapis/mcp-toolbox@v0.25.0...v0.26.0) (2026-01-22) ### ⚠ BREAKING CHANGES * Validate tool naming ([#2305](googleapis/mcp-toolbox#2305)) ([5054212](googleapis/mcp-toolbox@5054212)) * **tools/cloudgda:** Update description and parameter name for cloudgda tool ([#2288](googleapis/mcp-toolbox#2288)) ([6b02591](googleapis/mcp-toolbox@6b02591)) ### Features * Add new `user-agent-metadata` flag ([#2302](googleapis/mcp-toolbox#2302)) ([adc9589](googleapis/mcp-toolbox@adc9589)) * Add remaining flag to Toolbox server in MCP registry ([#2272](googleapis/mcp-toolbox#2272)) ([5e0999e](googleapis/mcp-toolbox@5e0999e)) * **embeddingModel:** Add embedding model to MCP handler ([#2310](googleapis/mcp-toolbox#2310)) ([e4f60e5](googleapis/mcp-toolbox@e4f60e5)) * **sources/bigquery:** Make maximum rows returned from queries configurable ([#2262](googleapis/mcp-toolbox#2262)) ([4abf0c3](googleapis/mcp-toolbox@4abf0c3)) * **prebuilt/cloud-sql:** Add create backup tool for Cloud SQL ([#2141](googleapis/mcp-toolbox#2141)) ([8e0fb03](googleapis/mcp-toolbox@8e0fb03)) * **prebuilt/cloud-sql:** Add restore backup tool for Cloud SQL ([#2171](googleapis/mcp-toolbox#2171)) ([00c3e6d](googleapis/mcp-toolbox@00c3e6d)) * Support combining multiple prebuilt configurations ([#2295](googleapis/mcp-toolbox#2295)) ([e535b37](googleapis/mcp-toolbox@e535b37)) * Support MCP specs version 2025-11-25 ([#2303](googleapis/mcp-toolbox#2303)) ([4d23a3b](googleapis/mcp-toolbox@4d23a3b)) * **tools:** Add `valueFromParam` support to Tool config ([#2333](googleapis/mcp-toolbox#2333)) ([15101b1](googleapis/mcp-toolbox@15101b1)) ### Bug Fixes * **tools/cloudhealthcare:** Add check for client authorization before retrieving token string ([#2327](googleapis/mcp-toolbox#2327)) ([c25a233](googleapis/mcp-toolbox@c25a233)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

duwenxin99 requested a review from a team January 14, 2026 21:05

blunderbuss-gcf Bot assigned Yuan325 Jan 14, 2026

gemini-code-assist Bot reviewed Jan 14, 2026

View reviewed changes

Comment thread internal/server/mcp/v20241105/method.go

Yuan325 reviewed Jan 14, 2026

View reviewed changes

Comment thread internal/server/mcp/v20241105/method.go

duwenxin99 requested review from a team and Yuan325 January 15, 2026 22:03

Yuan325 approved these changes Jan 16, 2026

View reviewed changes

Comment thread internal/server/mcp/v20250618/method.go

duwenxin99 force-pushed the mcp-sem branch from 7fb9a0a to da3b095 Compare January 20, 2026 23:25

duwenxin99 and others added 8 commits January 20, 2026 18:50

add embedding model in mcp

e4fca2d

add testing config

c394ab5

update other mcp versions

9ebb227

update table name

e3d6678

add alloydb and cloud sql tests

3d6f3e1

Change expected value in embedding tests

c7a00ae

Add API_KEY to secretEnv in cloudbuild.yaml

1f31c1a

Added API_KEY to secret environment variables for integration.

update list table test

a0eb6e6

duwenxin99 force-pushed the mcp-sem branch from 03f0a95 to a0eb6e6 Compare January 20, 2026 23:50

add new mcp version

70c10c4

duwenxin99 enabled auto-merge (squash) January 21, 2026 00:02

duwenxin99 merged commit e4f60e5 into main Jan 21, 2026
12 checks passed

duwenxin99 deleted the mcp-sem branch January 21, 2026 00:20

release-please Bot mentioned this pull request Jan 20, 2026

chore(main): release 0.26.0 #2286

Merged

github-actions Bot pushed a commit to dennisg/genai-toolbox that referenced this pull request Jan 21, 2026

deploy: fix(embeddingModel): add embedding model to MCP handler (goog…

20b91df

…leapis#2310) - Add embedding model to mcp handlers - Add integration tests e4f60e5

mahlevanshika pushed a commit to mahlevanshika/genai-toolbox that referenced this pull request Jan 22, 2026

fix(embeddingModel): add embedding model to MCP handler (googleapis#2310

8dcd12b

) - Add embedding model to mcp handlers - Add integration tests

BrewTestBot mentioned this pull request Jan 23, 2026

mcp-toolbox 0.26.0 Homebrew/homebrew-core#264117

Merged

kshalu-code pushed a commit to kshalu-code/genai-toolbox that referenced this pull request Feb 4, 2026

fix(embeddingModel): add embedding model to MCP handler (googleapis#2310

0d175bb

) - Add embedding model to mcp handlers - Add integration tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(embeddingModel): add embedding model to MCP handler#2310

fix(embeddingModel): add embedding model to MCP handler#2310
duwenxin99 merged 9 commits into
mainfrom
mcp-sem

duwenxin99 commented Jan 14, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jan 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

duwenxin99 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

duwenxin99 commented Jan 14, 2026 •

edited

Loading