Skip to content

feat: Add Cloud SQL for SQL Server Source and Tool#223

Merged
duwenxin99 merged 11 commits into
mainfrom
sqlserver
Jan 23, 2025
Merged

feat: Add Cloud SQL for SQL Server Source and Tool#223
duwenxin99 merged 11 commits into
mainfrom
sqlserver

Conversation

@duwenxin99

@duwenxin99 duwenxin99 commented Jan 17, 2025

Copy link
Copy Markdown
Contributor
  1. sql/database provides a Scan()interface to scan query results into typed variables. Therefore we have to create a slice of typed variables (types retrieved from rows.ColumnTypes()) to pass them into Scan(). Using []byte works but makes the printing result different from other tools (e.g [1] instead of %!s(int32=1)]
  2. MS SQL supports both named (e.g @name) and positional args (e.g @p2), so we have to check if the name is contained in the original statement before passing them into db.Query() as either named arg or as values.

@duwenxin99 duwenxin99 requested a review from a team January 17, 2025 14:49
@duwenxin99 duwenxin99 closed this Jan 17, 2025
@duwenxin99 duwenxin99 reopened this Jan 17, 2025
@github-actions

Copy link
Copy Markdown
Contributor

2 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@duwenxin99 duwenxin99 requested a review from kurtisvg January 17, 2025 15:42
Comment thread internal/sources/cloudsqlmssql/cloud_sql_mssql.go
Comment thread internal/tools/mssql/mssql.go Outdated
Comment thread internal/tools/mssql/mssql.go
@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Comment thread internal/tools/mssql/mssql.go Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@duwenxin99 duwenxin99 merged commit 9bad952 into main Jan 23, 2025
@duwenxin99 duwenxin99 deleted the sqlserver branch January 23, 2025 13:21
@github-actions

Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

Yuan325 pushed a commit that referenced this pull request Feb 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](v0.0.5...v0.1.0)
(2025-02-06)


### ⚠ BREAKING CHANGES

* **langchain-sdk:** The SDK for `toolbox-langchain` is now located
[here](https://github.com/googleapis/genai-toolbox-langchain-python).

### Features

* Add Cloud SQL for SQL Server Source and Tool
([#223](#223))
([9bad952](9bad952))
* Add Cloud SQL for MySQL Source and Tool
([#221](#221))
([f1f61d7](f1f61d7))
* Add Dgraph Source and Tool
([#233](#233))
([617cc87](617cc87))
* Add local quickstart
([#232](#232))
([497fb06](497fb06))
* Add user agents for cloud sources
([#244](#244))
([8452f8e](8452f8e))
* Add MySQL Source
([#250](#250))
([378692a](378692a))
* Add MSSQL source
([#255](#255))
([8fca0a9](8fca0a9))


### Bug Fixes

* Auth token verification failure should not throw error immediately
([#234](#234))
([4639cc6](4639cc6))
* Fix typo in postgres test
([#216](#216))
([0c3d12a](0c3d12a))
* **mssql:** Fix mssql tool kind to mssql-sql
([#249](#249))
([1357be2](1357be2))
* **mysql:** Fix mysql tool kind to mysql-sql
([#248](#248))
([669d6b7](669d6b7))
* Schema float type
([#264](#264))
([1702f74](1702f74))
* Typos at test cases
([#265](#265))
([b7c5661](b7c5661))
* Update README and quickstart with the correct async APIs.
([#269](#269))
([21eef2e](21eef2e))
* Update tool invoke to return json
([#266](#266))
([ad58cd5](ad58cd5))

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
1. `sql/database` provides a `Scan()`interface to scan query results
into typed variables. Therefore we have to create a slice of typed
variables (types retrieved from rows.ColumnTypes()) to pass them into
`Scan()`. Using []byte works but makes the printing result different
from other tools (e.g [1] instead of %!s(int32=1)]
2. MS SQL supports both named (e.g @name) and positional args (e.g @p2),
so we have to check if the name is contained in the original statement
before passing them into `db.Query()` as either named arg or as values.
jeffreyrubi pushed a commit to jeffreyrubi/genai-toolbox that referenced this pull request Jun 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](googleapis/mcp-toolbox@v0.0.5...v0.1.0)
(2025-02-06)


### ⚠ BREAKING CHANGES

* **langchain-sdk:** The SDK for `toolbox-langchain` is now located
[here](https://github.com/googleapis/genai-toolbox-langchain-python).

### Features

* Add Cloud SQL for SQL Server Source and Tool
([googleapis#223](googleapis#223))
([9bad952](googleapis@9bad952))
* Add Cloud SQL for MySQL Source and Tool
([googleapis#221](googleapis#221))
([f1f61d7](googleapis@f1f61d7))
* Add Dgraph Source and Tool
([googleapis#233](googleapis#233))
([617cc87](googleapis@617cc87))
* Add local quickstart
([googleapis#232](googleapis#232))
([497fb06](googleapis@497fb06))
* Add user agents for cloud sources
([googleapis#244](googleapis#244))
([8452f8e](googleapis@8452f8e))
* Add MySQL Source
([googleapis#250](googleapis#250))
([378692a](googleapis@378692a))
* Add MSSQL source
([googleapis#255](googleapis#255))
([8fca0a9](googleapis@8fca0a9))


### Bug Fixes

* Auth token verification failure should not throw error immediately
([googleapis#234](googleapis#234))
([4639cc6](googleapis@4639cc6))
* Fix typo in postgres test
([googleapis#216](googleapis#216))
([0c3d12a](googleapis@0c3d12a))
* **mssql:** Fix mssql tool kind to mssql-sql
([googleapis#249](googleapis#249))
([1357be2](googleapis@1357be2))
* **mysql:** Fix mysql tool kind to mysql-sql
([googleapis#248](googleapis#248))
([669d6b7](googleapis@669d6b7))
* Schema float type
([googleapis#264](googleapis#264))
([1702f74](googleapis@1702f74))
* Typos at test cases
([googleapis#265](googleapis#265))
([b7c5661](googleapis@b7c5661))
* Update README and quickstart with the correct async APIs.
([googleapis#269](googleapis#269))
([21eef2e](googleapis@21eef2e))
* Update tool invoke to return json
([googleapis#266](googleapis#266))
([ad58cd5](googleapis@ad58cd5))

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
NightStack15 added a commit to NightStack15/googleapis-_-genai-toolbox that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](googleapis/mcp-toolbox@v0.0.5...v0.1.0)
(2025-02-06)


### ⚠ BREAKING CHANGES

* **langchain-sdk:** The SDK for `toolbox-langchain` is now located
[here](https://github.com/googleapis/genai-toolbox-langchain-python).

### Features

* Add Cloud SQL for SQL Server Source and Tool
([#223](googleapis/mcp-toolbox#223))
([9bad952](googleapis/mcp-toolbox@9bad952))
* Add Cloud SQL for MySQL Source and Tool
([#221](googleapis/mcp-toolbox#221))
([f1f61d7](googleapis/mcp-toolbox@f1f61d7))
* Add Dgraph Source and Tool
([#233](googleapis/mcp-toolbox#233))
([617cc87](googleapis/mcp-toolbox@617cc87))
* Add local quickstart
([#232](googleapis/mcp-toolbox#232))
([497fb06](googleapis/mcp-toolbox@497fb06))
* Add user agents for cloud sources
([#244](googleapis/mcp-toolbox#244))
([8452f8e](googleapis/mcp-toolbox@8452f8e))
* Add MySQL Source
([#250](googleapis/mcp-toolbox#250))
([378692a](googleapis/mcp-toolbox@378692a))
* Add MSSQL source
([#255](googleapis/mcp-toolbox#255))
([8fca0a9](googleapis/mcp-toolbox@8fca0a9))


### Bug Fixes

* Auth token verification failure should not throw error immediately
([#234](googleapis/mcp-toolbox#234))
([4639cc6](googleapis/mcp-toolbox@4639cc6))
* Fix typo in postgres test
([#216](googleapis/mcp-toolbox#216))
([0c3d12a](googleapis/mcp-toolbox@0c3d12a))
* **mssql:** Fix mssql tool kind to mssql-sql
([#249](googleapis/mcp-toolbox#249))
([1357be2](googleapis/mcp-toolbox@1357be2))
* **mysql:** Fix mysql tool kind to mysql-sql
([#248](googleapis/mcp-toolbox#248))
([669d6b7](googleapis/mcp-toolbox@669d6b7))
* Schema float type
([#264](googleapis/mcp-toolbox#264))
([1702f74](googleapis/mcp-toolbox@1702f74))
* Typos at test cases
([#265](googleapis/mcp-toolbox#265))
([b7c5661](googleapis/mcp-toolbox@b7c5661))
* Update README and quickstart with the correct async APIs.
([#269](googleapis/mcp-toolbox#269))
([21eef2e](googleapis/mcp-toolbox@21eef2e))
* Update tool invoke to return json
([#266](googleapis/mcp-toolbox#266))
([ad58cd5](googleapis/mcp-toolbox@ad58cd5))

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants