docs: migrate to `toolbox-adk` and simplified `ToolboxToolset` by anubhav756 · Pull Request #2211 · googleapis/mcp-toolbox

anubhav756 · 2025-12-19T11:10:58Z

Updates all quickstart guides and samples to use the new toolbox-adk package instead of the legacy toolbox-core. Also updates ToolboxToolset usage to rely on the simplified constructor (implicit authentication) and ensures correct dependency installation.

Note

The integration tests are failing because the google-adk package is not released yet with the newer changes from toolbox-adk. This is expected behavior until the package update is released.

gemini-code-assist · 2025-12-19T11:11:19Z

Summary of Changes

Hello @anubhav756, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the documentation and sample code by migrating from the deprecated toolbox-core package to the new toolbox-adk. It also simplifies the instantiation and usage of ToolboxToolset by leveraging implicit authentication, making the examples more concise and aligned with current best practices. These changes ensure that users follow the most up-to-date methods for integrating with the toolbox ecosystem.

Highlights

Package Migration: All quickstart guides and samples have been updated to use the new toolbox-adk package, replacing the legacy toolbox-core.
Simplified Toolset Usage: The ToolboxToolset usage has been streamlined to rely on a simplified constructor, enabling implicit authentication.
Dependency Updates: Ensures correct dependency installation across documentation and samples, reflecting the new package structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request migrates ADK-based examples from the legacy toolbox-core to the new toolbox-adk package and updates the usage to a simpler ToolboxToolset constructor. The changes are generally good and align with the goal of simplifying the API.

However, I've noticed a couple of issues in the code samples that could affect users following the guides. I've left specific comments on these.

In colab_quickstart.ipynb, there's an inconsistent import path for ToolboxToolset.
In bigquery/local_quickstart.md, an asynchronous function is called without await, which will cause the sample to fail.

Additionally, the PR description states that 'all' quickstart guides are updated, but it seems the migration is focused only on the ADK examples. Other examples using toolbox-core, toolbox-langchain, etc., are not updated. It would be good to clarify the scope of this PR in the description.

github-actions · 2025-12-19T11:14:12Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2025-12-19T11:28:01Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2025-12-19T11:38:02Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2025-12-19T11:44:53Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-02T07:13:42Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-02T12:23:09Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-02T15:22:36Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-02T15:28:11Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-06T11:19:36Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-07T11:22:42Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-08T12:26:56Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

anubhav756 · 2026-01-08T17:28:53Z

/gcbrun

github-actions · 2026-01-27T09:17:59Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

…tion in BigQuery quickstart.

…r Python

…ll command

github-actions · 2026-01-28T04:25:19Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2211/

github-actions · 2026-01-28T05:57:20Z

🧨 Preview deployments removed.

#2211) Updates all quickstart guides and samples to use the new `toolbox-adk` package instead of the legacy `toolbox-core`. Also updates `ToolboxToolset` usage to rely on the simplified constructor (implicit authentication) and ensures correct dependency installation. > [!NOTE] > The integration tests are failing because the `google-adk` package is not released yet with the newer changes from `toolbox-adk`. This is expected behavior until the [package update](cl/853799009) is released. 362ed8d

googleapis#2211) Updates all quickstart guides and samples to use the new `toolbox-adk` package instead of the legacy `toolbox-core`. Also updates `ToolboxToolset` usage to rely on the simplified constructor (implicit authentication) and ensures correct dependency installation. > [!NOTE] > The integration tests are failing because the `google-adk` package is not released yet with the newer changes from `toolbox-adk`. This is expected behavior until the [package update](cl/853799009) is released. 362ed8d

…eapis#2211) Updates all quickstart guides and samples to use the new `toolbox-adk` package instead of the legacy `toolbox-core`. Also updates `ToolboxToolset` usage to rely on the simplified constructor (implicit authentication) and ensures correct dependency installation. > [!NOTE] > The integration tests are failing because the `google-adk` package is not released yet with the newer changes from `toolbox-adk`. This is expected behavior until the [package update](cl/853799009) is released.

anubhav756 requested review from a team December 19, 2025 11:10

blunderbuss-gcf Bot assigned duwenxin99 Dec 19, 2025

gemini-code-assist Bot reviewed Dec 19, 2025

View reviewed changes

Comment thread docs/en/getting-started/colab_quickstart.ipynb Outdated

Comment thread docs/en/samples/bigquery/local_quickstart.md Outdated

anubhav756 changed the title ~~docs: migrate to toolbox-adk and simplified ToolboxToolset~~ docs: migrate to toolbox-adk and simplified ToolboxToolset Dec 19, 2025

anubhav756 assigned anubhav756 and unassigned duwenxin99 Dec 19, 2025

anubhav756 force-pushed the docs/toolbox-adk-migration branch from 29695aa to 35088ac Compare December 19, 2025 11:41

anubhav756 requested review from averikitsch and kurtisvg December 19, 2025 16:32

averikitsch reviewed Dec 22, 2025

View reviewed changes

Comment thread docs/en/getting-started/quickstart/python/adk/quickstart.py Outdated

Yuan325 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels Dec 31, 2025

anubhav756 force-pushed the docs/toolbox-adk-migration branch from c854e4f to b7a3493 Compare January 2, 2026 12:20

anubhav756 requested a review from averikitsch January 2, 2026 18:26

anubhav756 force-pushed the docs/toolbox-adk-migration branch from e614069 to 1d2e21f Compare January 7, 2026 11:19

anubhav756 force-pushed the docs/toolbox-adk-migration branch from 1d2e21f to 6cf6fde Compare January 8, 2026 12:23

anubhav756 force-pushed the docs/toolbox-adk-migration branch from 30333f9 to 87929e6 Compare January 27, 2026 09:14

averikitsch approved these changes Jan 27, 2026

View reviewed changes

anubhav756 added 13 commits January 28, 2026 09:51

docs: migrate to toolbox-adk and simplified ToolboxToolset

6447a2a

fix: Adjusted ToolboxToolset import path.

594f01e

docs: wrap python sample in async main for correct session creation

bb9d720

docs: Remove toolset_name parameter from ToolboxToolset instantia…

8477aa8

…tion in BigQuery quickstart.

docs: simplify ToolboxToolset initialization by removing toolset_name

8ea8372

fix: Update toolbox-adk package version to fix quickstart tests

797ae1c

chore: Update toolbox-adk dependency to pick the latest version

daf6723

chore: Update adk dependency for toolbox

51ec7e4

chore: Simplify adk installation in colab quickstart

1f70066

doc: Add toolbox-adk as a dependency to the ADK deployment guide

a430089

doc: Simplify ADK installation steps in local quickstart

636ee51

doc: Simplify bigquery quickstart with updated ADK install command fo…

37d8354

…r Python

doc: Update ADK agent deployment guide with updated ADK package insta…

02bdcbe

…ll command

anubhav756 force-pushed the docs/toolbox-adk-migration branch from 87929e6 to 02bdcbe Compare January 28, 2026 04:21

anubhav756 merged commit 362ed8d into main Jan 28, 2026
13 checks passed

anubhav756 deleted the docs/toolbox-adk-migration branch January 28, 2026 05:56

Conversation

anubhav756 commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Dec 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 6, 2026

Uh oh!

github-actions Bot commented Jan 7, 2026

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

anubhav756 commented Jan 8, 2026

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anubhav756 commented Dec 19, 2025 •

edited

Loading