tests: ignore spanner test failures#2200
Conversation
Summary of ChangesHello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the reliability of Spanner integration tests by modifying the table teardown logic. By adding Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds IF EXISTS to the DROP TABLE statement in setupSpannerTable, which will improve the reliability of the integration tests by preventing failures during teardown. This is a good improvement. To further enhance test robustness, I have a suggestion:
For consistency, consider also adding IF EXISTS to the DROP PROPERTY GRAPH statement in the setupSpannerGraph function within the same file. This will prevent similar test flakiness, as DROP PROPERTY GRAPH also supports this clause.
Update `DROP TABLE %table_name` to `DROP TABLE IF EXISTS %tablename`. The drop table statement often fail to run. This halts the process and causes context timeout, and eventually failing the integration tests.
Update
DROP TABLE %table_nametoDROP TABLE IF EXISTS %tablename. The drop table statement often fail to run. This halts the process and causes context timeout, and eventually failing the integration tests.